Add support for hostname binding for http/https gateway#846
Merged
Add support for hostname binding for http/https gateway#846
Conversation
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
==========================================
- Coverage 89.23% 89.21% -0.02%
==========================================
Files 131 131
Lines 3595 3589 -6
==========================================
- Hits 3208 3202 -6
Misses 387 387
Continue to review full report at Codecov.
|
Member
Author
|
@bploetz Do not worry — enjoy your vacation. I think I'll move this over the finish line in meantime then :) |
Member
Author
|
@kevinswiber @bploetz Tests added. |
XVincentX
force-pushed
the
feature/gateway_listen_host
branch
from
a8723bd to
15bd49c
Compare
Member
Author
|
@bploetz Do not worry, it's perfectly fine. Is there any way you could test this on your servers and let me know if your use case is fulfilled? |
Member
Author
|
@bploetz This is because you haven't provided the https://www.express-gateway.io/docs/configuration/gateway.config.yml/https/ |
Member
Author
|
//cc @kevinswiber @altsang |
Member
Author
|
It should be in 1.14 — but I can’t give you an ETA for release. We still have some chores/errands to review and merge before putting it live. Hopefully soon :)
|
Member
Author
|
@bploetz This is now in 1.14.0 |
Contributor
|
Thanks for your patience on this Brian, sorry it took so long
On December 21, 2018 at 10:15:09 AM, Brian Ploetz (notifications@github.com) wrote:
Awesome! Thanks @XVincentX <https://github.com/XVincentX> !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#846 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACKAcZsG-bObH0Ro05S8ycxWExDPcNt0ks5u7SUsgaJpZM4YtyPB>
.
|
Contributor
|
HA! I *knew* it :P
On December 21, 2018 at 10:17:04 AM, Brian Ploetz (notifications@github.com) wrote:
No worries @altsang <https://github.com/altsang>. Had my package.json file
pointed at the sha in the mean time. :) Thanks again guys!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#846 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACKAcf4gLznnRAoV0cjNRwuUEAtRiACnks5u7SWggaJpZM4YtyPB>
.
|
gatherchou
pushed a commit
to yilu-tech/express-gateway
that referenced
this pull request
Jul 29, 2021
…eway_listen_host Add support for hostname binding for http/https gateway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing from #845
@bploetz I'd appreciate if you could actually try this branch on your system to confirm the feature is working correctly.