fix multiple creds support for 'jwt' and 'key-auth'#899
Merged
XVincentX merged 7 commits intoExpressGateway:masterfrom Apr 11, 2019
Merged
fix multiple creds support for 'jwt' and 'key-auth'#899XVincentX merged 7 commits intoExpressGateway:masterfrom
XVincentX merged 7 commits intoExpressGateway:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 89.07% 89.08% +0.01%
==========================================
Files 136 136
Lines 3688 3692 +4
==========================================
+ Hits 3285 3289 +4
Misses 403 403
Continue to review full report at Codecov.
|
XVincentX
requested changes
Apr 8, 2019
Member
XVincentX
left a comment
XVincentX
left a comment
There was a problem hiding this comment.
Hey,
thanks a lot for taking care of this! The pull request looks good, I just dropped some comments here and there to enhance it a little bit.
Thanks!
Co-Authored-By: nakardo <diegonake@gmail.com>
Co-Authored-By: nakardo <diegonake@gmail.com>
Co-Authored-By: nakardo <diegonake@gmail.com>
Co-Authored-By: nakardo <diegonake@gmail.com>
XVincentX
reviewed
Apr 10, 2019
Member
XVincentX
left a comment
XVincentX
left a comment
There was a problem hiding this comment.
This now generally feels ok. I need to pull down your branch and make some smoke tests to make sure we do not screw up anything. Good job though, I think this is going to get merged really soon.
XVincentX
approved these changes
Apr 11, 2019
gatherchou
pushed a commit
to yilu-tech/express-gateway
that referenced
this pull request
Jul 29, 2021
…ressGateway#856 fix multiple creds support for 'jwt' and 'key-auth' closes ExpressGateway#856
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #856
Also introduces changes on the
credentials.test.jstests to make sure other policies work as intended.