fix[UI]: improve consent page#907
Merged
XVincentX merged 5 commits intoExpressGateway:masterfrom Apr 28, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #907 +/- ##
==========================================
+ Coverage 88.85% 88.85% +<.01%
==========================================
Files 137 137
Lines 3722 3724 +2
==========================================
+ Hits 3307 3309 +2
Misses 415 415
Continue to review full report at Codecov.
|
Member
|
Hey @ravikp7 — good start. There are couple of additional things I'd like to see here though
I know this can be annoying — just let me know in case you're not up for it and I will take it over the finish line. |
Contributor
Author
|
@XVincentX yeah, the scope consent page is still pending, will take care of that as well as the styling and logo |
ravikp7
force-pushed
the
oauth-consent-page
branch
from
055e7d3 to
c474640
Compare
Contributor
Author
|
- add styling and logo - show requesting scopes in consent page fixes ExpressGateway#739
ravikp7
force-pushed
the
oauth-consent-page
branch
from
c474640 to
2681d74
Compare
Contributor
Author
|
Member
|
Sweet! I'll review and merge! |
gatherchou
pushed a commit
to yilu-tech/express-gateway
that referenced
this pull request
Jul 29, 2021
fix[UI]: improve consent page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #739