OAuth2-Introspect plugin was always using the same passport strategy#942
Merged
XVincentX merged 4 commits intoExpressGateway:masterfrom Sep 7, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #942 +/- ##
==========================================
+ Coverage 88.96% 88.97% +<.01%
==========================================
Files 137 137
Lines 3735 3737 +2
==========================================
+ Hits 3323 3325 +2
Misses 412 412
Continue to review full report at Codecov.
|
XVincentX
approved these changes
Sep 7, 2019
Member
XVincentX
left a comment
XVincentX
left a comment
There was a problem hiding this comment.
Looks good, thanks for the long investigation. I've pushed the change for you and merging/releasing this.
XVincentX
force-pushed
the
fix/oauth2-introspect_multiple_pipelines
branch
from
1a3949b to
452dccc
Compare
gatherchou
pushed a commit
to yilu-tech/express-gateway
that referenced
this pull request
Jul 29, 2021
…spect_multiple_pipelines OAuth2-Introspect plugin was always using the same passport strategy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OAuth2 Introspection was hitting always the latest endpoint configured, in whichever pipeline.
Please have a look at this for more info.
@XVincentX here is the related PR to the matter discussed in the above referenced link :-)