[FreshEyes] Mempool util: Add RBF diagram checks for single chunks against clusters of size 2#107
Open
Extheoisah wants to merge 9 commits into
Conversation
Co-authored-by: Suhas Daftuar <sdaftuar@chaincode.com> Co-authored-by: Pieter Wuille <pieter.wuille@gmail.com>
Co-authored-by: Suhas Daftuar <sdaftuar@chaincode.com>
This new function takes the populated sets of direct and all conflicts computed in the current mempool, assuming the replacements are a single chunk, and computes a diagram check. The diagram check only works against cluster sizes of 2 or less, and fails if it encounters a different topology. Co-authored-by: Suhas Daftuar <sdaftuar@chaincode.com>
Co-authored-by: Suhas Daftuar <sdaftuar@chaincode.com>
Co-authored-by: Suhas Daftuar <sdaftuar@chaincode.com> Co-authored-by: Pieter Wuille <pieter.wuille@gmail.com>
|
There were 49 comments left by 5 reviewers, 1 bot and the author for this pull request |
![fresheyes-staging-bot[bot]](https://avatars.githubusercontent.com/in/855196?s=60&v=4){kind=small}
| FeeFrac p1{1000, 100}, p2{500, 300}; | ||
| FeeFrac sum{1500, 400}; | ||
| FeeFrac diff{500, -200}; | ||
| FeeFrac empty{0, 0}; |
There was a problem hiding this comment.
3 authors commented here with:
- comment link
https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1453501485at 2024/01/16, 14:24:35 UTC - comment link
https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1455418545at 2024/01/17, 12:19:19 UTC - comment link
https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1459253460at 2024/01/19, 16:01:40 UTC.
| { | ||
| FeeFrac p1{1000, 100}, p2{500, 300}; | ||
| FeeFrac sum{1500, 400}; | ||
| FeeFrac diff{500, -200}; |
There was a problem hiding this comment.
4 authors commented here with:
- comment link
https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1453502118at 2024/01/16, 14:25:01 UTC - comment link
https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1455433932at 2024/01/17, 12:26:54 UTC - comment link
https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1455544265at 2024/01/17, 13:19:22 UTC - comment link
https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1459253396at 2024/01/19, 16:01:37 UTC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author instagibbs wrote the following PR called Mempool util: Add RBF diagram checks for single chunks against clusters of size 2, issue number 29242 in bitcoin/bitcoin cloned by FreshEyes below:
This is a smaller piece of
https://github.com/bitcoin/bitcoin/pull/28984broken off for easier review.Up to date explanation of diagram checks are here: https://delvingbitcoin.org/t/mempool-incentive-compatibility/553
This infrastructure has two near term applications prior to cluster mempool:
https://github.com/bitcoin/bitcoin/pull/28984): We want to allow package RBF only when we know it improves the mempool. This narrowly scoped functionality allows use with v3-like topologies, and will be expanded at some point post-cluster mempool when diagram checks can be done efficiently against bounded cluster sizes.ImprovesFeerateDiagraminterface will have to change for this use-case, which is a future direction to solve certain pins and improve mempool incentive compatibility: https://delvingbitcoin.org/t/ephemeral-anchors-and-mev/383#diagram-checks-fix-this-3And longer-term, this would be the proposed way we would compute incentive compatibility for all conflicts, post-cluster mempool.