fix(tools): canonical JSON Schema for chat tools

[chubes4]

Why

Data Machine 0.106.1 PR #1900 ("Require canonical AI tool schemas") removes the auto-normalization layer in RequestBuilder::normalizeToolParameters that previously converted legacy property-keyed parameter shapes into canonical JSON Schema on the way to providers. Extension plugins must now ship canonical schemas directly.

This is a pre-flight fix landed before the DM bump — canonical schemas already work on DM 0.103.14 (current production on extrachill.com), so this PR can ship and deploy independently of the DM upgrade.

What changed

Converted all 9 chat tool definitions in inc/Api/Chat/Tools/ from the legacy shape:

// Legacy
'parameters' => array(
    'venue' => array( 'type' => 'string', 'required' => true, 'description' => '...' ),
)

…to canonical JSON Schema:

// Canonical
'parameters' => array(
    'type'       => 'object',
    'properties' => array(
        'venue' => array( 'type' => 'string', 'description' => '...' ),
    ),
    'required'   => array( 'venue' ),
)

Files

• inc/Api/Chat/Tools/EventHealthCheck.php
• inc/Api/Chat/Tools/EventQualityAudit.php
• inc/Api/Chat/Tools/FindBrokenTimezoneEvents.php
• inc/Api/Chat/Tools/FixEventTimezone.php
• inc/Api/Chat/Tools/GetVenueEvents.php
• inc/Api/Chat/Tools/TestEventScraper.php
• inc/Api/Chat/Tools/UpdateEvent.php
• inc/Api/Chat/Tools/UpdateVenue.php
• inc/Api/Chat/Tools/VenueHealthCheck.php

The original task scoped this to 6 files. The remaining 3 (EventHealthCheck, FindBrokenTimezoneEvents, GetVenueEvents) had identical legacy shapes and would have broken on DM 0.106.1 too — converting all 9 in one PR makes the pre-flight actually pre-flight.

Conversion rules applied

1. Wrap properties under { type: 'object', properties: {...} }.
2. Move required => true properties into a top-level required[] array of property names; remove required from individual property defs.
3. Drop required => false entirely (it was a no-op).
4. Omit required key when no properties are required (don't emit empty arrays).
5. Every type: array property gains an items schema (required by OpenAI strict tool-schema validation, see MEMORY.md). Choices made:
   • FixEventTimezone.events → items: { type: object } (array of update structs)
   • UpdateEvent.events → items: { type: object } (array of update structs)
   • UpdateEvent.occurrenceDates → items: { type: string } (array of YYYY-MM-DD date strings)
6. All other property keys (description, enum) preserved verbatim.

Required fields summary

• UpdateVenue: venue
• TestEventScraper: target_url
• GetVenueEvents: venue
• All others have no required fields (optional-only schemas).

Out of scope (intentionally)

• inc/Steps/Upsert/Events/EventUpsertFilters.php — verified. Its parameters array is built dynamically by merging output from EventSchemaProvider::getCoreToolParameters(), EventSchemaProvider::getSchemaToolParameters(), TaxonomyHandler::getTaxonomyToolParameters(), and VenueParameterProvider::getToolParameters(). Those provider methods still emit the legacy property-keyed shape, but the entry point is handler tool registration, not chat tools — different code path through Data Machine's pipeline engine. Worth a follow-up audit before DM 0.106.1 deploys, but separate from this PR.

Backwards compatibility

Canonical schemas are accepted by both DM 0.103.14 (current production) and DM 0.106.1+ (target). The legacy normalization path on 0.103.x silently passes canonical schemas through. No behavior change on the current site.

Test plan

• PHP syntax check (php -l) passes on all 9 edited files.
• homeboy lint --path . --changed-since main shows no findings on any of the 9 edited tool files (only pre-existing baseline noise in UniversalWebScraper.php and other unrelated files).
• Verified converted schemas match the contract in DM 0.106.1 RequestBuilder::normalizeToolParameters passthrough path.
• Live tool calls in production chat post-merge (manual sanity check on at least update_venue and event_quality_audit).

Constraints honored

• Branched off main, no commits to main.
• No CHANGELOG.md edits, no version constant bumps — homeboy owns those.
• No deploy, no release.

[homeboy-ci]

Homeboy Results — data-machine-events

Audit

✅ audit — passed

• dead_code — 9 finding(s)
• test_coverage — 9 finding(s)
• Total: 18 finding(s)

Deep dive: homeboy audit data-machine-events --changed-since e1f629a

Tooling versions

• Homeboy CLI: homeboy 0.163.1+28edfdb
• Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
• Extension revision: 56b5c09
• Action: Extra-Chill/homeboy-action@v2