Skip to content

Refactor Reddit fetches onto core fresh candidates#136

Merged
chubes4 merged 1 commit into
mainfrom
refactor/core-candidate-collector
May 6, 2026
Merged

Refactor Reddit fetches onto core fresh candidates#136
chubes4 merged 1 commit into
mainfrom
refactor/core-candidate-collector

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented May 6, 2026

Summary

  • Refactors pipeline-driven Reddit fetches to use Data Machine core FreshCandidateCollector for selection-time processed/claimed/reprocess eligibility.
  • Removes the old Reddit processed_items ability handoff and direct CLI/chat compatibility fallbacks.
  • Adds focused coverage for processed top-of-feed results and pagination to later fresh candidates.

Fixes #135.

Tests

  • php -l inc/Handlers/Reddit/Reddit.php && php -l inc/Abilities/Reddit/FetchRedditAbility.php && php -l inc/Cli/Commands/RedditCommand.php && php -l inc/Chat/Tools/FetchReddit.php && php -l tests/Unit/Abilities/Reddit/FetchRedditAbilityTest.php
  • homeboy lint --path /Users/chubes/Developer/data-machine-socials@refactor-core-candidate-collector --changed-only --errors-only --summary
  • homeboy lint --path /Users/chubes/Developer/data-machine-socials@refactor-core-candidate-collector --file tests/Unit/Abilities/Reddit/FetchRedditAbilityTest.php --errors-only --summary
  • homeboy test --path /Users/chubes/Developer/data-machine-socials@refactor-core-candidate-collector -- tests/Unit/Abilities/Reddit/FetchRedditAbilityTest.php — 2 passed, 0 failed
  • npm run build

Caveats

  • Full repo lint still reports unrelated pre-existing findings outside this change; changed runtime PHP and new test lint pass.
  • Test run emitted a non-fatal Action Scheduler bootstrap notice.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (openai/gpt-5.5)
  • Used for: Refactoring Reddit candidate selection onto the Data Machine core fresh-candidate primitive and updating tests. Chris remains responsible for review and merge.

@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented May 6, 2026

Homeboy Results — data-machine-socials

Audit

audit — passed

  • parallel-implementation — 26 finding(s)
  • test_coverage — 18 finding(s)
  • dead_code — 5 finding(s)
  • intra-method-duplication — 4 finding(s)
  • repeated_literal_shape — 2 finding(s)
  • Total: 55 finding(s)

Deep dive: homeboy audit data-machine-socials --changed-since aca2263

Tooling versions
  • Homeboy CLI: homeboy 0.157.1+a5b426802
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 9290561
  • Action: Extra-Chill/homeboy-action@v2

@chubes4 chubes4 merged commit c961a02 into main May 6, 2026
1 check passed
@chubes4 chubes4 deleted the refactor/core-candidate-collector branch May 6, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Reddit fetch pagination onto Data Machine fresh-candidate primitive

1 participant