refactor: use TanStack Query cache as single source of truth for chat messages#218
Merged
chubes4 merged 1 commit intoFeb 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates dual-state race conditions in ChatSidebar by using TanStack Query cache as the single source of truth for chat messages.
Changes
ChatSidebar.jsx:
useStatefor messages — reads directly fromuseChatSession()query dataqueryClient.setQueryDatainstead ofsetMessagespendingUserMessagestate until the session is created and cache is seededuseEffectsyncingsessionQuery.data.conversation → setMessagesuseEffectforsessionQuery.error(handled inline)useChatTurn.js:
processToCompletionnow acceptsqueryClientinstead ofonNewMessagescallbackcontinueTurnupdates query cache directly viaappendMessagesToCachehelperqueries/chat.js: No changes needed —
staleTime: Infinityalready prevents cache overwrites.Why This Works
['chat-session', sessionId]staleTime: Infinityensures our optimistic updates aren't overwritten by refetchesFixes #210
Fixes #4
Fixes #5