Skip to content

feat(import-history): sidebar integration#116

Merged
JonnyTran merged 52 commits into
developfrom
feat/import-history-sidebar
Aug 6, 2025
Merged

feat(import-history): sidebar integration#116
JonnyTran merged 52 commits into
developfrom
feat/import-history-sidebar

Conversation

@JonnyTran
Copy link
Copy Markdown
Member

List of commits in feat/import-history-sidebar since develop:

311c23a Update metadata fields in dataset configuration and improve metadata description
f1c2fb6 added metadata selector
68a0e45 skip creating record metadata for all fieldName
2b797fe latest
ab8e9e3 latest
6492085 Add import-history dataset import endpoint and frontend support
7b43bfd Add float32 and boolean types to features and subsets
3d16b2c Improve dataset import: smarter schema/type inference and question suggestions
c499554 10.1 Style Recent Imports components
cbf223a fix styling
facad44 fix styling
d81c89f fix useLanguageDirection.ts
bf1728c fix errors
cf8022f fix: importData.getRawData is not a function
52afa3d 8.2 Update home page view model
5a06587 fix ImportHistoryListItem
24769eb latest
1335c83 fix RecentImports workspaces on load issue
f4e6efe fix: use BaseInputContainer as input-container
79526b4 fix: selects first when workspaces loads
2df5d6e 8.1 Modify home page sidebar
358b3f5 8.1 Modify home page sidebar
5ea7c6e 7.3 Update DatasetConfiguration view model
61415f4 [ ] 7.3 Update DatasetConfiguration view model
21485a6 7.1 Modify DatasetConfiguration component props
b078172 6. Create Import Configuration Page
796bb61 5.1 Create ImportHistoryDataPreview component
fbf2a32 4.3 Create RecentImports view model
40ed823 4.2 Create RecentImportCard component
d6bbc6f 4.1 Create RecentImports component
d3acb6d 3. Create ImportHistory Dataset Builder
1fa121c Merge branch 'develop' into feat/import-history-sidebar
4b17188 1. Enhance backend ImportHistory API for Recent Imports
aa93c74 kiro task list finalize

JonnyTran and others added 30 commits August 3, 2025 12:34
…ggestions

- Enhance type mapping to handle more Table Schema types (e.g., 'str', 'number', 'datetime', 'any')
- Infer metadata types from both schema and sample data for 'any' fields
- Use content analysis to detect text annotation fields instead of hardcoded names
- Suggest questions based on schema types and data (e.g., label selection for booleans/low-cardinality strings, rating for numeric fields)
- Ensure FieldType is correctly serialized as a string in repository methods
Fix MetadataTypes typo, add terms type, and rename adapteType to adaptedType

Enhance ImportHistoryDatasetBuilder to handle metadata types correctly

Update MetadataRepository to use adaptedType property
Implements a new /import-history API endpoint for importing datasets
from import history, and updates the frontend to use it when needed.
JonnyTran and others added 5 commits August 4, 2025 21:53
…description

- Added a header for the metadata section in the DatasetConfigurationForm component.
- Changed default metadata fields from "imdb" to "pmid" in both DatasetConfigurationForm and DatasetConfigurationMetadataSelector components.
- Updated the metadata description in the translation file to reflect sorting instead of filtering.
@JonnyTran JonnyTran requested a review from a team as a code owner August 5, 2025 20:19
@JonnyTran JonnyTran self-assigned this Aug 5, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 53.73444% with 223 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ents/features/import/ImportHistoryDetailsModal.vue 0.00% 68 Missing ⚠️
...illa-server/src/argilla_server/jobs/import_jobs.py 33.33% 60 Missing ⚠️
...iguration/DatasetConfigurationMetadataSelector.vue 0.00% 35 Missing ⚠️
...reation/configuration/DatasetConfigurationForm.vue 0.00% 16 Missing ⚠️
...d/components/features/import/ImportHistoryList.vue 0.00% 13 Missing ⚠️
argilla-frontend/pages/index.vue 0.00% 13 Missing ⚠️
...nents/features/import/ImportHistoryDataPreview.vue 95.86% 5 Missing ⚠️
...rgilla_server/api/handlers/v1/datasets/datasets.py 42.85% 4 Missing ⚠️
...rver/src/argilla_server/api/handlers/v1/imports.py 70.00% 3 Missing ⚠️
...-frontend/components/base/base-modal/BaseModal.vue 0.00% 2 Missing ⚠️
... and 2 more
Flag Coverage Δ
argilla 66.42% <ø> (?)
argilla-server 85.00% <43.69%> (?)
frontend 11.31% <57.02%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ponents/base/base-simple-table/BaseSimpleTable.vue 25.00% <ø> (ø)
.../configuration/shared/DatasetConfigurationCard.vue 0.00% <ø> (ø)
...nd/components/features/documents/DocumentsList.vue 0.00% <ø> (ø)
...components/features/import/ImportAnalysisTable.vue 61.85% <ø> (ø)
...rontend/components/features/import/ImportModal.vue 49.76% <100.00%> (ø)
...ntend/components/features/import/ImportSummary.vue 0.00% <ø> (ø)
...ntend/components/features/import/RecentImports.vue 100.00% <100.00%> (ø)
...rver/src/argilla_server/api/schemas/v1/datasets.py 98.37% <100.00%> (ø)
...erver/src/argilla_server/api/schemas/v1/imports.py 100.00% <100.00%> (ø)
argilla-server/src/argilla_server/contexts/hub.py 92.41% <100.00%> (ø)
... and 13 more
Components Coverage Δ
extralit ∅ <ø> (?)
argilla 66.42% <ø> (?)
argilla_v1 ∅ <ø> (?)
argilla-server 85.00% <43.69%> (?)
argilla-frontend 11.31% <57.02%> (?)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…styling for better user experience.

- Refactored ImportHistoryList component to streamline search and pagination logic.
- Introduced new methods in useImportHistoryListViewModel for better handling of filters and pagination.
- Adjusted API response structure for import history to include additional metadata and improved data handling.
- Removed unnecessary modal state management from index.vue, delegating it to useHomeViewModel for cleaner code.
- Updated the ImportHistoryDetails component to utilize a new simplified use case for fetching import history details directly.
- Removed pagination and filtering logic from the component, transitioning to client-side handling.
- Enhanced the useImportHistoryDetailsViewModel to process and summarize import history data more effectively.
- Adjusted related types and interfaces to align with the new data structure and response format.
- Updated the ImportHistoryResponse interface to include a structured metadata object with documents and summary.
- Refactored the useImportHistoryDetailsViewModel to utilize the new ImportSummary type for better data handling.
- Adjusted the calculateSummary method to derive summary information from the updated metadata structure.
- Improved the GetImportHistoryDetailsUseCase to align with the new metadata format, ensuring accurate processing of import history details.
…improved functionality and styling

- Updated BaseSimpleTable.vue to enhance TypeScript type definitions and streamline SCSS styles for better maintainability.
- Adjusted ImportHistoryDataPreview.vue to remove hardcoded pagination size, implementing dynamic pagination based on data length.
- Simplified the get-import-history-use-case.ts by utilizing shorthand property names for the limit parameter.
…r experience

- Introduced new formatting methods in ImportHistoryDataPreview.vue for boolean, number, and URL display.
- Removed the ImportHistoryDetails component and its associated view model, streamlining the import history handling.
- Updated ImportHistoryList.vue to simplify the data loading process and removed unnecessary filters.
- Enhanced the index.vue to manage import history modals more effectively, improving user interaction.
- Adjusted the GetImportHistoryUseCase to limit filters to workspace_id and user_id for cleaner API requests.
- Renamed 'uploaded_by' to 'username' across ImportHistoryList.vue and related use cases for clarity.
- Updated ImportHistoryResponse and related schemas to replace 'user_id' with 'username' for a more descriptive response.
- Introduced ImportHistoryCreateResponse schema to standardize the response for import history creation.
- Adjusted API endpoints to align with the new response structures, enhancing data handling and consistency.
…and functionality

- Added Jest testing patterns to the structure documentation for better test organization and clarity.
- Updated ImportAnalysisTable.spec.js to include comprehensive mock setups for view models and props.
- Refactored ImportAnalysisTable.vue to streamline local state management and introduced a retryAnalysis method for improved functionality.
- Enhanced the useImportAnalysisViewModel.ts to include the retryAnalysis function, ensuring proper analysis handling based on props changes.
@JonnyTran JonnyTran requested a review from a team as a code owner August 6, 2025 00:50
@JonnyTran JonnyTran merged commit c7e955a into develop Aug 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant