Skip to content

[FEAT] Rename question in Dataset Configuration#117

Merged
JonnyTran merged 56 commits into
developfrom
feat/import-history-sidebar
Aug 6, 2025
Merged

[FEAT] Rename question in Dataset Configuration#117
JonnyTran merged 56 commits into
developfrom
feat/import-history-sidebar

Conversation

@JonnyTran
Copy link
Copy Markdown
Member

No description provided.

JonnyTran and others added 30 commits August 3, 2025 12:34
…ggestions

- Enhance type mapping to handle more Table Schema types (e.g., 'str', 'number', 'datetime', 'any')
- Infer metadata types from both schema and sample data for 'any' fields
- Use content analysis to detect text annotation fields instead of hardcoded names
- Suggest questions based on schema types and data (e.g., label selection for booleans/low-cardinality strings, rating for numeric fields)
- Ensure FieldType is correctly serialized as a string in repository methods
Fix MetadataTypes typo, add terms type, and rename adapteType to adaptedType

Enhance ImportHistoryDatasetBuilder to handle metadata types correctly

Update MetadataRepository to use adaptedType property
Implements a new /import-history API endpoint for importing datasets
from import history, and updates the frontend to use it when needed.
JonnyTran and others added 22 commits August 5, 2025 12:32
…description

- Added a header for the metadata section in the DatasetConfigurationForm component.
- Changed default metadata fields from "imdb" to "pmid" in both DatasetConfigurationForm and DatasetConfigurationMetadataSelector components.
- Updated the metadata description in the translation file to reflect sorting instead of filtering.
…styling for better user experience.

- Refactored ImportHistoryList component to streamline search and pagination logic.
- Introduced new methods in useImportHistoryListViewModel for better handling of filters and pagination.
- Adjusted API response structure for import history to include additional metadata and improved data handling.
- Removed unnecessary modal state management from index.vue, delegating it to useHomeViewModel for cleaner code.
- Updated the ImportHistoryDetails component to utilize a new simplified use case for fetching import history details directly.
- Removed pagination and filtering logic from the component, transitioning to client-side handling.
- Enhanced the useImportHistoryDetailsViewModel to process and summarize import history data more effectively.
- Adjusted related types and interfaces to align with the new data structure and response format.
- Updated the ImportHistoryResponse interface to include a structured metadata object with documents and summary.
- Refactored the useImportHistoryDetailsViewModel to utilize the new ImportSummary type for better data handling.
- Adjusted the calculateSummary method to derive summary information from the updated metadata structure.
- Improved the GetImportHistoryDetailsUseCase to align with the new metadata format, ensuring accurate processing of import history details.
…improved functionality and styling

- Updated BaseSimpleTable.vue to enhance TypeScript type definitions and streamline SCSS styles for better maintainability.
- Adjusted ImportHistoryDataPreview.vue to remove hardcoded pagination size, implementing dynamic pagination based on data length.
- Simplified the get-import-history-use-case.ts by utilizing shorthand property names for the limit parameter.
…r experience

- Introduced new formatting methods in ImportHistoryDataPreview.vue for boolean, number, and URL display.
- Removed the ImportHistoryDetails component and its associated view model, streamlining the import history handling.
- Updated ImportHistoryList.vue to simplify the data loading process and removed unnecessary filters.
- Enhanced the index.vue to manage import history modals more effectively, improving user interaction.
- Adjusted the GetImportHistoryUseCase to limit filters to workspace_id and user_id for cleaner API requests.
- Renamed 'uploaded_by' to 'username' across ImportHistoryList.vue and related use cases for clarity.
- Updated ImportHistoryResponse and related schemas to replace 'user_id' with 'username' for a more descriptive response.
- Introduced ImportHistoryCreateResponse schema to standardize the response for import history creation.
- Adjusted API endpoints to align with the new response structures, enhancing data handling and consistency.
…and functionality

- Added Jest testing patterns to the structure documentation for better test organization and clarity.
- Updated ImportAnalysisTable.spec.js to include comprehensive mock setups for view models and props.
- Refactored ImportAnalysisTable.vue to streamline local state management and introduced a retryAnalysis method for improved functionality.
- Enhanced the useImportAnalysisViewModel.ts to include the retryAnalysis function, ensuring proper analysis handling based on props changes.
@JonnyTran JonnyTran requested review from a team as code owners August 6, 2025 03:53
@JonnyTran JonnyTran self-assigned this Aug 6, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../configuration/shared/DatasetConfigurationCard.vue 0.00% 17 Missing ⚠️
...reation/configuration/DatasetConfigurationForm.vue 0.00% 13 Missing ⚠️
...uration/questions/DatasetConfigurationQuestion.vue 0.00% 4 Missing ⚠️
...configuration/fields/DatasetConfigurationField.vue 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c7e955a) and HEAD (0c58271). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c7e955a) HEAD (0c58271)
argilla-server 1 0
Flag Coverage Δ
argilla-server ?
frontend 11.25% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...n/container/questions/form/Questions.component.vue 0.00% <ø> (ø)
...configuration/fields/DatasetConfigurationField.vue 0.00% <0.00%> (ø)
...uration/questions/DatasetConfigurationQuestion.vue 0.00% <0.00%> (ø)
...reation/configuration/DatasetConfigurationForm.vue 0.00% <0.00%> (ø)
.../configuration/shared/DatasetConfigurationCard.vue 0.00% <0.00%> (ø)

... and 174 files with indirect coverage changes

Components Coverage Δ
extralit ∅ <ø> (∅)
argilla 66.42% <ø> (ø)
argilla_v1 ∅ <ø> (∅)
argilla-server ∅ <ø> (∅)
argilla-frontend 11.25% <0.00%> (-0.07%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JonnyTran JonnyTran merged commit 5030a1b into develop Aug 6, 2025
5 of 6 checks passed
@JonnyTran JonnyTran deleted the feat/import-history-sidebar branch August 12, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant