[FIX] Import Files Flow#120
Merged
Merged
Conversation
- Add performant CSV parser (papaparse) and types - Implement CSV preview and column selection UI for reference/files columns - Refactor BibTeX/CSV parsing logic into FileService - Add PdfMatchingService for PDF-to-reference matching - Update DI to register new services - Update package.json and lock for new dependencies - Add unit tests for file parsing and dataframe building - Update import UI to support .csv files and show preview/selection - Mark CSV parser task as complete in specs
- Updated BaseFlowModal.spec.js to correct the stub for BaseButton. - Improved formatting in ImportHistoryDataPreview.spec.js and other test files for consistency.
- Updated ImportAnalysisTable.vue to improve import information display and remove unnecessary import mode logic. - Introduced new components for managing import history, including ImportHistoryDataPreview.vue and ImportHistoryDetailsModal.vue. - Added RecentImports.vue and RecentImportCard.vue for displaying recent import records with improved UI and error handling. - Implemented useRecentImportsViewModel for managing recent imports state and interactions. - Enhanced tests for recent imports components and view models to ensure reliability and coverage.
…into feat/import-file-flow
- Deleted ImportAnalysisTable.vue and its corresponding test file ImportAnalysisTable.spec.js to streamline the import functionality. - Removed useImportAnalysisTableViewModel.ts as it was no longer needed after the component removal. - Updated ImportBatchProgress.vue to utilize a filtered version of dataframe data for import history creation, ensuring only relevant references are included.
- Removed the Import Information section from ImportAnalysisTable.vue to streamline the UI. - Updated RecentImports.vue to expose a refresh method for parent component interaction. - Added a refresh method in useRecentImportsViewModel.ts to reload recent imports. - Modified handleImportCompleted in useHomeViewModel.ts to refresh recent imports after import completion. - Updated index.vue to reference the RecentImports component for improved import flow handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the design and requirements documentation for both the Import History Sidebar and the Papers Library Importer features. The main focus is on replacing the old
ImportModalworkflow with a new, more flexibleImportFlowthat supports both.biband.csvbibliography imports, enhanced PDF-to-reference matching, and improved user control over the import process. The documentation changes also clarify UI event handling, backend integration, and error handling for these workflows.Import Workflow Modernization and Flexibility:
ImportModalwithImportFlow, ensuring the main import workflow supports both.biband.csvfiles, and updated event handlers and requirements to reflect this change. (.kiro/specs/import-history-sidebar/design.md [1] [2] .kiro/specs/import-history-sidebar/requirements.md [3] .kiro/specs/import-history-sidebar/tasks.md [4] .kiro/specs/papers-library-importer/design.md [5] [6] [7]Bibliography and PDF Import Improvements:
.csvbibliography files with user-selectable reference and files columns, column preview, and flexible schema handling; improved CSV error handling and parsing. (.kiro/specs/papers-library-importer/design.md [1] [2] [3] .kiro/specs/papers-library-importer/requirements.md [4] [5]Import Analysis and User Controls:
ignore), and provide user options to import all references or only those with matched PDFs, automatically setting unmatched references toignoreas needed. (.kiro/specs/papers-library-importer/design.md [1] .kiro/specs/papers-library-importer/requirements.md [2]Other Documentation and API Schema Updates:
usernameinstead ofuser_idfor better clarity in UI. (.kiro/specs/papers-library-importer/design.md .kiro/specs/papers-library-importer/design.mdL437-R456)These changes collectively modernize the import experience, provide more flexibility for users, and improve the maintainability and clarity of the import-related code and documentation.