Skip to content

[FEAT] Workspace Pinia Store and Dataset Breadcrumb Selector in AppHeader#121

Merged
JonnyTran merged 21 commits into
developfrom
feat/workspace-pinia-store
Aug 9, 2025
Merged

[FEAT] Workspace Pinia Store and Dataset Breadcrumb Selector in AppHeader#121
JonnyTran merged 21 commits into
developfrom
feat/workspace-pinia-store

Conversation

@JonnyTran
Copy link
Copy Markdown
Member

This pull request implements the "Global Workspace Selector" feature, transforming workspace selection into a centralized, persistent system integrated into the application's breadcrumb navigation. The changes introduce a new requirements document and implementation plan, and refactor the BaseBreadcrumbs component to support workspace and dataset dropdowns directly in the breadcrumb UI. This enables users to switch workspaces and datasets from anywhere in the app, with state managed globally and persistently.

The most important changes are:

Requirements and Planning

  • Added a comprehensive requirements document outlining user stories, acceptance criteria, and technical expectations for the global workspace selector feature. (.kiro/specs/global-workspace-selector/requirements.md)
  • Added a detailed implementation plan breaking down tasks, sub-tasks, and their mapping to requirements for building the global workspace selector, including storage, UI, error handling, and testing. (.kiro/specs/global-workspace-selector/tasks.md)

Breadcrumb Component Refactor

  • Refactored BaseBreadcrumbs.vue to render workspace and dataset breadcrumb dropdown components (WorkspaceBreadcrumbDropdown and DatasetBreadcrumbDropdown) when the breadcrumb item is marked as such, enabling direct selection from the breadcrumb navigation. (extralit-frontend/components/base/base-breadcrumbs/BaseBreadcrumbs.vue)
  • Updated the script section of BaseBreadcrumbs.vue to use TypeScript, import new types and dropdown components, and strongly type props and events for better maintainability and clarity. (extralit-frontend/components/base/base-breadcrumbs/BaseBreadcrumbs.vue)
  • Enhanced event handling and styling in BaseBreadcrumbs.vue to support workspace switching, propagate events to parent components, and visually distinguish workspace/dataset breadcrumbs, improving user experience and consistency. (extralit-frontend/components/base/base-breadcrumbs/BaseBreadcrumbs.vue) [1] [2]

@JonnyTran JonnyTran requested review from a team as code owners August 9, 2025 23:18
@JonnyTran JonnyTran self-assigned this Aug 9, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 9, 2025

Codecov Report

❌ Patch coverage is 0.72464% with 137 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ase/base-breadcrumbs/DatasetBreadcrumbDropdown.vue 0.00% 59 Missing ⚠️
...e/base-breadcrumbs/WorkspaceBreadcrumbDropdown.vue 0.00% 56 Missing ⚠️
...mponents/base/base-breadcrumbs/BaseBreadcrumbs.vue 0.00% 17 Missing ⚠️
...ponents/features/home/dataset-list/DatasetList.vue 0.00% 4 Missing ⚠️
...-frontend/components/features/global/AppHeader.vue 0.00% 1 Missing ⚠️
Flag Coverage Δ
frontend 10.59% <0.72%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nnotation/header/header-bar/HeaderFeedbackTask.vue 68.00% <100.00%> (+1.33%) ⬆️
...nd/components/features/documents/DocumentsList.vue 0.00% <ø> (ø)
...s/features/import/analysis/ImportAnalysisTable.vue 56.56% <ø> (ø)
...nts/features/user-settings/UserSettingsContent.vue 0.00% <ø> (ø)
extralit-frontend/pages/index.vue 0.00% <ø> (ø)
...-frontend/components/features/global/AppHeader.vue 0.00% <0.00%> (ø)
...ponents/features/home/dataset-list/DatasetList.vue 0.00% <0.00%> (ø)
...mponents/base/base-breadcrumbs/BaseBreadcrumbs.vue 0.00% <0.00%> (ø)
...e/base-breadcrumbs/WorkspaceBreadcrumbDropdown.vue 0.00% <0.00%> (ø)
...ase/base-breadcrumbs/DatasetBreadcrumbDropdown.vue 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
extralit 64.93% <ø> (ø)
extralit-server ∅ <ø> (∅)
extralit-frontend 10.59% <0.72%> (-0.12%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JonnyTran JonnyTran requested a review from a team as a code owner August 9, 2025 23:36
@JonnyTran JonnyTran merged commit 48beba4 into develop Aug 9, 2025
1 check passed
@JonnyTran JonnyTran deleted the feat/workspace-pinia-store branch August 12, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant