Skip to content

[FIX] Import File Parsing and Matching Flow and Refactoring#122

Merged
JonnyTran merged 12 commits into
developfrom
fix/import-flow-handling
Aug 12, 2025
Merged

[FIX] Import File Parsing and Matching Flow and Refactoring#122
JonnyTran merged 12 commits into
developfrom
fix/import-flow-handling

Conversation

@JonnyTran
Copy link
Copy Markdown
Member

@JonnyTran JonnyTran commented Aug 12, 2025

This pull request refactors the bibliography data handling throughout the import flow to use the dataframeData structure instead of the legacy parsedEntries array. It also fixes the logic for enabling the "Next" button in the import flow, ensuring that users can proceed after a successful bibliography upload regardless of PDF upload status, and supports flexible upload order. Additionally, it updates related components and types for consistency and maintainability.

Import Flow Logic and UI Improvements

  • Fixed the "Next" button enablement logic in ImportFlow.vue to check for valid bibliography data using dataframeData instead of parsedEntries, allowing users to proceed after uploading the bibliography, regardless of PDF upload status. This supports flexible upload order (bibliography or PDFs first). [1] [2] [3]
  • Updated the handleBibUpdate method and related logic in ImportFlow.vue to properly populate parsedEntries from dataframeData and ensure UI reflects the new data structure. [1] [2]

Data Structure and Prop Refactoring

  • Removed all usage and references to parsedEntries in favor of dataframeData across the import components, including ImportFileUpload.vue, ImportSummarySidebar.vue, and their props, computed properties, and watchers. [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Updated the ImportSummarySidebar.vue and related UI to display the bibliography reference count using dataframeData instead of parsedEntries. [1] [2]

Data Synchronization and File Matching

  • Added a method to update dataframeData with matched PDF file paths in ImportFileUpload.vue, ensuring that each bibliography entry is associated with its corresponding PDF(s) for downstream analysis. [1] [2]

Type and Import Consistency

  • Updated type imports and prop types to use TableData instead of DataframeData in analysis-related components and view models, ensuring type consistency. [1] [2] [3] [4] [5]

Specification and Documentation

  • Marked the error handling task as completed and documented the fix for the import flow's next button logic in the project specification file. [1] [2]

@JonnyTran JonnyTran requested review from a team as code owners August 12, 2025 03:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 2.77778% with 35 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/features/import/file-upload/ImportFileUpload.vue 0.00% 22 Missing ⚠️
...frontend/components/features/import/ImportFlow.vue 0.00% 4 Missing ⚠️
...onents/features/import/file-upload/TableUpload.vue 0.00% 4 Missing ⚠️
...mponents/features/import/file-upload/PdfUpload.vue 0.00% 3 Missing ⚠️
...atures/import/file-upload/ImportSummarySidebar.vue 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2e25184) and HEAD (156bbee). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (2e25184) HEAD (156bbee)
extralit-server 1 0
Flag Coverage Δ
extralit-server ?
frontend 10.58% <2.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/features/import/analysis/ImportAnalysisTable.vue 56.75% <100.00%> (+0.19%) ⬆️
...features/import/file-upload/CsvColumnSelection.vue 0.00% <ø> (ø)
...atures/import/file-upload/ImportSummarySidebar.vue 0.00% <0.00%> (ø)
...mponents/features/import/file-upload/PdfUpload.vue 0.00% <0.00%> (ø)
...frontend/components/features/import/ImportFlow.vue 22.93% <0.00%> (+0.10%) ⬆️
...onents/features/import/file-upload/TableUpload.vue 0.00% <0.00%> (ø)
...s/features/import/file-upload/ImportFileUpload.vue 0.00% <0.00%> (ø)

... and 184 files with indirect coverage changes

Components Coverage Δ
extralit 64.89% <ø> (-0.04%) ⬇️
extralit-server ∅ <ø> (∅)
extralit-frontend 10.58% <2.77%> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JonnyTran JonnyTran merged commit 9348cb6 into develop Aug 12, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant