[FIX] Import File Parsing and Matching Flow and Refactoring#122
Merged
Conversation
…e for cleaner code
…it into fix/import-flow-handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the bibliography data handling throughout the import flow to use the
dataframeDatastructure instead of the legacyparsedEntriesarray. It also fixes the logic for enabling the "Next" button in the import flow, ensuring that users can proceed after a successful bibliography upload regardless of PDF upload status, and supports flexible upload order. Additionally, it updates related components and types for consistency and maintainability.Import Flow Logic and UI Improvements
ImportFlow.vueto check for valid bibliography data usingdataframeDatainstead ofparsedEntries, allowing users to proceed after uploading the bibliography, regardless of PDF upload status. This supports flexible upload order (bibliography or PDFs first). [1] [2] [3]handleBibUpdatemethod and related logic inImportFlow.vueto properly populateparsedEntriesfromdataframeDataand ensure UI reflects the new data structure. [1] [2]Data Structure and Prop Refactoring
parsedEntriesin favor ofdataframeDataacross the import components, includingImportFileUpload.vue,ImportSummarySidebar.vue, and their props, computed properties, and watchers. [1] [2] [3] [4] [5] [6] [7] [8] [9]ImportSummarySidebar.vueand related UI to display the bibliography reference count usingdataframeDatainstead ofparsedEntries. [1] [2]Data Synchronization and File Matching
dataframeDatawith matched PDF file paths inImportFileUpload.vue, ensuring that each bibliography entry is associated with its corresponding PDF(s) for downstream analysis. [1] [2]Type and Import Consistency
TableDatainstead ofDataframeDatain analysis-related components and view models, ensuring type consistency. [1] [2] [3] [4] [5]Specification and Documentation