[FEAT] minio presigned url for pdf#124
Merged
Merged
Conversation
- Added console logging to `GetDocumentByIdUseCase` for improved debugging of document retrieval. - Introduced a `limit` parameter in the `add_document` and `find_existing_documents` functions to control the number of results returned. - Updated the `delete_documents` function to include type ignoring for compatibility. - Refactored the `list_documents` function to streamline document validation and retrieval.
…ue with dockerd - Updated `.env.dev` to reflect the new S3 endpoint at port 9001, ensuring compatibility with the local MinIO setup.
- Added error logging in `useDeleteDatasetViewModel` for better debugging during dataset deletion failures. - Updated `User` entity to safely handle optional `userName` when generating avatar. - Introduced presigned URL generation for document access in the `get_document` function, ensuring valid file URLs. - Refactored document retrieval logic to support presigned URLs and improved metadata handling in document schemas. - Enhanced file handling in the context to ensure compatibility with S3 storage requirements.
- Replaced the existing MinIO client dependency with singleton across various document and file handling endpoints. - Updated the `CHANGELOG.md` to reflect the changes in endpoint behavior and client handling. - Enhanced document retrieval logic to support multiple identifiers in a single request, improving API usability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across the backend and frontend, with a focus on enhancing document and file handling, S3/MinIO integration, and user experience. The most significant changes include the addition of presigned URL generation for document access, improved S3/MinIO bucket management during user creation, and better compatibility for S3 metadata. There are also updates to API schemas, Docker/MinIO configuration, and error handling in the frontend.
Document and File Handling Improvements
get_documentendpoint, ensuring returned document URLs are valid and time-limited for secure access.S3/MinIO Integration and Compatibility
9001:9000) and enabled the proper network for the MinIO service. [1] [2]API and Schema Updates
GET /documentsendpoint to support multiple identifiers and return multiple documents in order, with improved error messages.DocumentUpdateandDocumentListItemschemas to support a URL field and ensure returned URLs are always present and valid.Frontend and Developer Experience
avatargetter in theUserentity to prevent runtime errors.Changelog and Documentation
These changes collectively improve the robustness, security, and usability of the system, particularly around document access and storage.