Open
Conversation
oda
reviewed
May 29, 2024
| class Solution: | ||
| def lengthOfLIS(self, nums: List[int]) -> int: | ||
| MAX_NUM = 10 ** 4 | ||
| MIN_NUM = -(10 ** 4) |
There was a problem hiding this comment.
この括弧不要では。
あと、こういうマジックナンバーはあまり行儀がいい感じがしないですね。
入力の制約を守らない入力を入れると、理解できない振る舞いをするんですよね。
数年間使うコードならば、そういうことは間違いなく起きますよね。
それに対して、入力の制約を守らなかったのが悪いのだから、デバッグに一日潰しても潰したやつが悪い、というのは良い同僚ではないでしょう。
Owner
Author
There was a problem hiding this comment.
たしかにそうですね~
となると、10 ** 18とかを入れるのがbetterでしょうか?
また、定義するときはINF = 10 ** 18とかってやっちゃってもよいんですかね...?
Pythonにはfloat('inf')がありますが、速度が遅いのであまり使いたくないなあという気持ちです。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題:https://leetcode.com/problems/longest-increasing-subsequence/description/
参考:
https://github.com/sakupan102/arai60-practice/pull/32/files
https://leetcode.com/problems/longest-increasing-subsequence/solutions/4509129/99-54-easy-solution-with-explanation/