Merged
Conversation
kzmkt
reviewed
May 13, 2024
kzmkt
left a comment
kzmkt
left a comment
There was a problem hiding this comment.
シンプルでいいと思います。
元の引数名が悪いので仕方がないですが、s → text, c → character とかくらいが見やすいかもですね。
聞かれてもおかしくないのは「defaultdict使わずにかけますか？」くらいですかね？
enemurateまでは冗長なだけなので、同じこと聞かれる気はあまりしないです。
| for i, c in enumerate(s): | ||
| if char_count[c] == 1: | ||
| return i | ||
| return -1 |
There was a problem hiding this comment.
-1 がどのような意味を持つのかコードを見るだけだと分からないので、定数にして役割に準じた名前をつけたり、コードコメントを残すといったことをした方がいいように思いました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題：https://leetcode.com/problems/first-unique-character-in-a-string/description
参考：
https://github.com/sakupan102/arai60-practice/pull/16/files
https://github.com/hayashi-ay/leetcode/pull/28/files