Updates (detail in desc.) #32
Description
Hi,
I made the following updates to my local copy of relay_Guide.ash and realized, while they are minor, I could help.
I've never tried to create a pull request, before--is there a command I can use from within the kolmafia client to submit the pull request?
tl;dr update: I think I fixed everything in the details. They all appear to be minor issues. I'm happy to create the (above-mentioned) pull request but have no clue how to proceed.
Details:
Changing "Frat House" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 4411, char 29 to char 39)
Changing "Asdon Martin keyfob" to "Asdon Martin keyfob (on ring)" would get rid of this message. (relay_Guide.ash, line 4498, char 39 to char 58)
Changing "Asdon Martin keyfob" to "Asdon Martin keyfob (on ring)" would get rid of this message. (relay_Guide.ash, line 4499, char 34 to char 53)
Changing "hippy camp" to "The Hippy Camp" would get rid of this message. (relay_Guide.ash, line 6021, char 26 to char 36)
Changing "frat house" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 16750, char 176 to char 188)
Changing "hippy camp" to "The Hippy Camp" would get rid of this message. (relay_Guide.ash, line 16750, char 188 to char 200)
Changing "Frat House" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 32023, char 31 to char 41)
Changing "video game level 1" to "[DungeonFAQ - Level 1]" would get rid of this message. (relay_Guide.ash, line 32927, char 29 to char 47)
Changing "hippy camp" to "The Hippy Camp" would get rid of this message. (relay_Guide.ash, line 33549, char 199 to char 209)
Changing "frat house" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 33574, char 214 to char 224)
Changing "frat house" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 33574, char 272 to char 282)
Changing "frat house" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 33574, char 334 to char 344)
Changing "frat house" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 33574, char 418 to char 428)
Changing "frat house" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 33574, char 502 to char 512)
Changing "frat house" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 33574, char 576 to char 586)
Changing "frat house" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 33574, char 651 to char 661)
Changing "frat house" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 33574, char 731 to char 741)
Changing "frat house" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 33590, char 193 to char 203)
Changing "Asdon Martin keyfob" to "Asdon Martin keyfob (on ring)" would get rid of this message. (relay_Guide.ash, line 35752, char 34 to char 53)
Changing "Frat House" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 39879, char 83 to char 93)
Changing "Hippy Camp" to "The Hippy Camp" would get rid of this message. (relay_Guide.ash, line 39881, char 83 to char 93)
Changing "video game level 1" to "[DungeonFAQ - Level 1]" would get rid of this message. (relay_Guide.ash, line 42210, char 90 to char 109)
Changing "video game level 2" to "[DungeonFAQ - Level 2]" would get rid of this message. (relay_Guide.ash, line 42210, char 109 to char 128)
Changing "video game level 3" to "[DungeonFAQ - Level 3]" would get rid of this message. (relay_Guide.ash, line 42210, char 128 to char 147)
Changing "Asdon martin keyfob" to "Asdon Martin keyfob (on ring)" would get rid of this message. (relay_Guide.ash, line 48832, char 31 to char 50)
Changing "Asdon martin keyfob" to "Asdon Martin keyfob (on ring)" would get rid of this message. (relay_Guide.ash, line 48857, char 31 to char 50)
Changing "hippy camp" to "The Hippy Camp" would get rid of this message. (relay_Guide.ash, line 52603, char 52 to char 62)
Changing "Frat House" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 54448, char 73 to char 83)
Changing "hippy camp" to "The Hippy Camp" would get rid of this message. (relay_Guide.ash, line 55149, char 54 to char 64)
Changing "frat house" to "The Orcish Frat House" would get rid of this message. (relay_Guide.ash, line 55170, char 54 to char 64)
The following, I did not correct:
Function 'to_buffer(string)' overrides a library function. (relay_Guide.ash, line 1826, char 8 to char 29)
Warning: Preference '_summonResortPassUsed' is deprecated. Use numeric _summonResortPassesUsed instead
Warning: Preference '_summonResortPassUsed' is deprecated. Use numeric _summonResortPassesUsed instead
You gain 4,439 Meat
Warning: Preference '_summonResortPassUsed' is deprecated. Use numeric _summonResortPassesUsed instead
If I figure it out, I'll provide an update.
Update:
Renamed function to_buffer() to to_my_buffer(). Replaced all calls.
I am unable to resolve the _summonResortPassUsed deprecated item. Here's what I've found:
- https://kolmafia.us/threads/issue-with-constant-messages-wrt-deprecated-preference.30695/
- Above item 1 points to: https://github.com/loathers/TourGuide/pull/256
A little more searching and I found:
3. https://github.com/loathers/TourGuide/blob/c25f77b72fc3e6a8840907b15d16f65c54f5c6c1/Source/relay/TourGuide/Sets/Skills.ash#L209
So I replaced _summonResortPassUsed with _summonResortPassesUsed
I'm hoping that's the correct change.