Fix floating point slice indices in _string_rep in Cython 3.1.* #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracked down the issue preventing `TestString::test_large_list` from passing when compiling with Cython 3.1.*. Specifically, the issue came down to the calculated `num_rows` in `_string_rep` staying floating point instead of getting cast to an int. I'm not sure whether Cython 3.1.* broke variable shadowing, or optimized out `num_rows = int(num_rows)`... or something else. But in any case, we can avoid the floating point operations (and float-typed variable) by switching _string_rep to use the following formula for calculating the celing of integer division: `ceil(x / y) = (x + y - 1) // y` Since all tests now pass on Cython 3.1.*, this change also removes the upper constraints on Cython. Fixes: Ezibenroc#134
Owner
|
Hello and sorry for the late answer. Good catch, it's great that we will be able to unpin Cython ! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked down the issue preventing
TestString::test_large_listfrom passing when compiling with Cython 3.1.*.Specifically, the issue came down to the calculated
num_rowsin_string_repstaying floating point instead of getting cast to an int.I'm not sure whether Cython 3.1.* broke variable shadowing, or optimized out
num_rows = int(num_rows)... or something else. But in any case, we can avoid the floating point operations (and float-typed variable) by switching _string_rep to use the following formula for calculating the celing of integer division:ceil(x / y) = (x + y - 1) // ySince all tests now pass on Cython 3.1.*, this change also removes the upper constraints on Cython.
Fixes: #134