Skip to content

default to using credentials directory#25

Merged
iam-veeramalla merged 2 commits intoF5Networks:masterfrom
chen23:default-cred-dir
May 29, 2019
Merged

default to using credentials directory#25
iam-veeramalla merged 2 commits intoF5Networks:masterfrom
chen23:default-cred-dir

Conversation

@chen23
Copy link
Copy Markdown
Contributor

@chen23 chen23 commented May 8, 2019

change default secret behavior from environment variable to credentials directory

Comment thread src/incubator/f5-bigip-ctlr/templates/f5-bigip-ctlr-deploy.yaml
Comment thread src/incubator/f5-bigip-ctlr/templates/f5-bigip-ctlr-deploy.yaml
Comment thread src/stable/f5-bigip-ctlr/Chart.yaml Outdated
@ghost
Copy link
Copy Markdown

ghost commented May 10, 2019

@chen23 : can you update the requested changes ?

@chen23
Copy link
Copy Markdown
Contributor Author

chen23 commented May 10, 2019

I've resolved the conversations. Thank you.

@ghost
Copy link
Copy Markdown

ghost commented May 14, 2019

@chen23 - Can you please share the contents of Credentials directory. This will help me document and validate this MR.

@chen23
Copy link
Copy Markdown
Contributor Author

chen23 commented May 15, 2019

Here's details on the contents of the of the file (it's the secret that contains the BIG-IP username/password): https://kubernetes.io/docs/concepts/configuration/secret/#using-secrets

@ghost
Copy link
Copy Markdown

ghost commented May 15, 2019

Here's details on the contents of the of the file (it's the secret that contains the BIG-IP username/password): https://kubernetes.io/docs/concepts/configuration/secret/#using-secrets

Thank you.

Copy link
Copy Markdown
Collaborator

@iam-veeramalla iam-veeramalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge. Tested this locally by trinath

Copy link
Copy Markdown
Collaborator

@iam-veeramalla iam-veeramalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge. tested locally by trinath

@iam-veeramalla iam-veeramalla merged commit ba4167e into F5Networks:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants