fix little bugs#1403
Open
zhang-shengping wants to merge 1 commit intoF5Networks:masterfrom
Open
Conversation
delete extra '"""'
zhang-shengping
requested review from
Niklaus-xie,
jikui,
olvandeng,
zhaoqin-github and
zongzw
zongzw
approved these changes
Jan 29, 2019
Niklaus-xie
suggested changes
Jan 29, 2019
Contributor
Niklaus-xie
left a comment
Niklaus-xie
left a comment
There was a problem hiding this comment.
code looks fine. but perhaps not rush to merge this for now. since we might revert the original one. so perhaps integrate those 2 commits into one later. put a -2 here for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cause error log: AttributeError: "'NoneType' object has no attribute 'find_subnet_route_domain'"
fixs:
self.network_helper none problem
delete extra '"""'