This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Conversation
Issues: Fixes #60 Problem: The setup.py installation of this repo does not require the proper python client libraries for glance and keystone. This is currently done in the f5-openstack-heat template with an apt-get install (which is not correct). We'll move it to the setup.py here and then update the heat template to remove that installation. The other big point is that we are installation from latest with apt-get, so we're unsure of what we're getting when we do the heat template install. With the setup.py change, we'll fix it to a particular version that is tested and works. Analysis: Added install_requires to have the keystone and glance client for openstack. These are pinned to specific versions. Those versions will change between libert and mitaka etc. Tests: Tested with heat deployment from f5-openstack-heat repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Fixes #60
Problem:
The setup.py installation of this repo does not require the proper
python client libraries for glance and keystone. This is currently done
in the f5-openstack-heat template with an apt-get install (which is not
correct). We'll move it to the setup.py here and then update the heat
template to remove that installation. The other big point is that we are
installation from latest with apt-get, so we're unsure of what we're
getting when we do the heat template install. With the setup.py change,
we'll fix it to a particular version that is tested and works.
Analysis:
Added install_requires to have the keystone and glance client for
openstack. These are pinned to specific versions. Those versions will
change between libert and mitaka etc.
Tests:
Tested with heat deployment from f5-openstack-heat repo.