Missing from __future__ import annotations #2808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents failure to import in Python 3.8
Contributor
Author
|
fwiw, a local build with Python 3.8 for mac-arm worked fine with this patch. conda-forge/fenics-dolfinx-feedstock#47 may take an hour or two to finish. |
Contributor
Author
|
conda-forge/fenics-dolfinx-feedstock#47 passed with this and #2810 |
jhale
pushed a commit
that referenced
this pull request
Oct 10, 2023
prevents failure to import in Python 3.8 Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevents failure to import dolfinx.mesh in Python 3.8 due to the use of
tuple[...], which requires Python 3.9. Since this is in an annotation, deferring annotation evaluation via the annotations__future__ought to work, as is done in some other files already.This suggests that there aren't CI jobs to verify that dolfinx builds and then imports with Python 3.8, I think?
testing in conda-forge/fenics-dolfinx-feedstock#47 if you want to wait for that to confirm this is sufficient.