Run Actions with OpenMPI and MPICH, and remove CircleCI config #3185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhale
approved these changes
Apr 30, 2024
Member
jhale
left a comment
jhale
left a comment
There was a problem hiding this comment.
Looks good. The doc publish step could potentially be done by packing up artefacts between steps (avoids a build) but I'm not sure it's worth the extra complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCI was used to run tests using MPICH. The PR brings OpenMPI and MPICH under Actions.
To simplify also, also splits documentation publishing into its own step/job.