Add C++ demo that shows mixed elements and consistency fixes for element spaces #3500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… garth/cpp-mixed-demo
chrisrichardson
approved these changes
Nov 15, 2024
jorgensd
added a commit
to jorgensd/dolfinx_mpc
that referenced
this pull request
Nov 17, 2024
jorgensd
added a commit
to jorgensd/dolfinx_mpc
that referenced
this pull request
Nov 17, 2024
* Update CI versions and behavior * Refactor timings, due to: FEniCS/dolfinx#3487 FEniCS/dolfinx#3488 * API changes from: FEniCS/dolfinx#3500 * Fix demo * Install boost * Set tag * Only check docker on release branch * Fixes for refernece value size * More timing fixes * Another round of timing changes * Remove last old timing instance
This was referenced Nov 19, 2024
schnellerhase
pushed a commit
to schnellerhase/fenics-dolfinx
that referenced
this pull request
Dec 28, 2024
…ent spaces (FEniCS#3500) * Start on C++ mixed method example * Tidy up demo * Undo change * Lint fix * Tidy up * Simplification * Fix forwarding * Remove redundant function argument * Formatting * Wrapper update * Consistency fixes * Fix * Undo changes * Consistency fixes * Undo some changes * Updates * Update * Small fix * More updates * Enable demo * Updates * Improve readability * Small updates * Add CMake file * Solver fix * Change solver * Try mumps * Verbose test * Action update * Print matrix norm * Test image path update * Update solve * Docker update * CI update * Demo update * Split create FunctionSpace function * Updates * Update * Revert * Revert * Updates * Tidy up * Small fixes * Small edits * Simplifications * Logic fix * Attempt fix * Revert * Change solver * Updates * Update * Simplify * Simplify * Update test * Test update * Enable demo * Tidy up * Simplification * Simplification * Demo update * Doc fix * Updates * Wrapper fix * Test updates * Quad element update * Update test * Test fix * Updates * Test update * Remove value_shape from function space * Lint * Constructor fix * Tidy * Tidy up * Tidy * Work on docs * Doc updates * Doc updates * Simplification * Revert some lines * Add comment * Small fix * Tidy up * Simplify * Work on doc * Type fix * Doc updates * Update docs * Doc improvements * Type fix * Switch solver for PETSc 64-bit int * Small fix * Small change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mixed Poisson C++ demo. It is the first mixed method C++ demo added to DOLFINx.
Adding this demo exposed some bugs, incorrect docs and some clumsy code. Fixes include:
FunctionSpaceand andFiniteElementboth have a value shape, which is usually the same (redundant) and sometimes different (confusing). AFunctionSpaceno longer stores a value size.FiniteElement, it was unclear how 'blocked' elements were handled and the docs were inconsistent. The is now made clear.std::reference_wrapperis now used in containers in interfaces where appropriate in place of a shared pointer.std::optionalis now used inFiniteElementfor value shape data. This removed confusion around isstd::vector<std::size_t>{}unset or is it the value shape for a scalar?There are no changes to the Python interface.