Modify demo_helmholtz.py to solve for plane wave solution in complex mode #3563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We aim to have demos and tests run (near) identical code in real and complex cases. Otherwise testing is problematic. Can you make the real case run the same code? Setting the NumPy type should discard the complex part when computing with reals. Also, run |
Contributor
Author
|
Thank you for the feedback, I was indeed able to consolidate the real/complex code paths. In the real mode the script will simply solve for the real part of the complex exponential (I updated the introductory comments accordingly). I also fixed the lint errors found using ruff. |
garth-wells
approved these changes
Dec 23, 2024
garth-wells
approved these changes
Dec 23, 2024
Member
|
Resolves #3557 |
schnellerhase
pushed a commit
to schnellerhase/fenics-dolfinx
that referenced
this pull request
Dec 28, 2024
…mode (FEniCS#3563) * modify demo_helmholtz.py to solve for plane wave solution in complex mode * consolidate code b/t real and complex modes; ruff linter fixes * Run ruff format * Small tidy up --------- Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal change addressing the issue raised in #3557