Improve nested fieldsplit preconditioning setup on *Problem classes
#3752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
added
demo
jhale
reviewed
Jun 16, 2025
jorgensd
commented
Jun 16, 2025
jorgensd
commented
Jun 16, 2025
nate-sime
reviewed
Jun 17, 2025
Co-authored-by: Nate <34454754+nate-sime@users.noreply.github.com>
jhale
reviewed
Jul 2, 2025
jhale
changed the title
dolfinx.fem.petsc.LinearProblem can be used with fieldsplit*Problem classes
Member
|
The current implementation gives the user a fieldsplit name of e.g. |
ordinary-slim
pushed a commit
to ordinary-slim/dolfinx
that referenced
this pull request
Jul 6, 2025
…FEniCS#3752) * Use new linear-rproblem for mixed poisson * Example of mixed poisson with fieldsplit * Grammar - hyphen removal * Ruff formatting * Add suggested PETSc log printing for monitor by Nate Co-authored-by: Nate <34454754+nate-sime@users.noreply.github.com> * Ruff formatting * Update demo_mixed-poisson.py * Update demo_mixed-poisson.py * Reformat. * Add missing destructor for P_mat * Transfer IS on P_mat to outer PC. * Tweaks. * Fix. * Add name to Functions * ruff * Fix SNES. * Without names the prefix is the same as PETSc's defaults. * Update SNES * Tidy. * Add new stokes solve demo. --------- Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk> Co-authored-by: Nate <34454754+nate-sime@users.noreply.github.com> Co-authored-by: Jack S. Hale <mail@jackhale.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a nested preconditioner operator is passed, transfer the IS up to the outer PC object so that fieldsplit preconditioning is enabled. The field name is based off of the Function name appended with the fieldsplit index, however this is an implementation detail and users should always get the prefix rather than typing it explicitly.
Edited by @jhale.