-
-
Notifications
You must be signed in to change notification settings - Fork 228
Force non random order of execution for C++ tests #3852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
garth-wells
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will work due to the hdf5-mpi package depending on OpenMPI.
Which function call is leading to the hang with OpenMPI ?
|
|
|
But the problem appears to be open-mpi 5.0.7 -> 5.0.8. After a local update I can reproduce it. |
Any particular line in DOLFINx, or is it any call to |
|
Any call. |
|
I can't reproduce failure locally on macOS and with OpenMPI 5.0.8 from Homebrew. |
|
|
|
Maybe race condition. Cycling |
7690c34 to
38f760b
Compare
|
Found it - was not the open-mpi bump, but the catch2 update. New version changes default behaviour of execution order to random https://github.com/catchorg/Catch2/releases/tag/v3.9.0. This means, on every process a different execution order of the test cases is generated. So MPI communications of different test cases, in particular with different data types line up, causing all kinds of incorrect data or unmatched communications. |
Catch2
>=3.9.0changes execution order to random by default. This needs to be deactivated for MPI parallel testing.