Pullback: remove FunctionSpace #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
commented
Dec 9, 2025
pbrubeck
commented
Dec 9, 2025
pbrubeck
commented
Dec 9, 2025
pbrubeck
commented
Dec 9, 2025
pbrubeck
force-pushed
the
pbrubeck/fix/pullback-remove-functionspace
branch
from
7cf3636 to
123cd79
Compare
mscroggs
approved these changes
Dec 17, 2025
Member
mscroggs
left a comment
mscroggs
left a comment
There was a problem hiding this comment.
Looks sensible, and I think we can merge once we work out why one test has started failing
Contributor
Author
The test added in #448 failed with the |
pbrubeck
added a commit
to firedrakeproject/ufl
that referenced
this pull request
Dec 22, 2025
* Pullback: remove FunctionSpace * cast to int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
FunctionSpacefrom pullback.py