Skip to content

214 implement first iteration of table#406

Open
dafn wants to merge 47 commits intomainfrom
214-implement-first-iteration-of-table
Open

214 implement first iteration of table#406
dafn wants to merge 47 commits intomainfrom
214-implement-first-iteration-of-table

Conversation

@dafn
Copy link
Copy Markdown
Collaborator

@dafn dafn commented Apr 9, 2026

No description provided.

fhi-designsystem-bot and others added 30 commits February 25, 2026 15:32
@fhi-designsystem-bot
okay lets go!
83f4aef
@fhi-designsystem-bot
wip
a55e114
@fhi-designsystem-bot
wip using grid. missing rows
b823ffd
@fhi-designsystem-bot
add rows functionality to grid
3dc7acc
@fhi-designsystem-bot
edit the docs
3a54f97
@dafn
change rows docs
9871f69
@dafn
Merge branch '378-add-rows-to-grid' of https://github.com/FHIDev/Fhi.…
5078eeb 
…Designsystem into 214-implement-first-iteration-of-table
@dafn
wip
4a21b19
@dafn
try out some examples
f28524b
@dafn
add some tokens
6ca2dee
@dafn
Merge branch 'main' of https://github.com/FHIDev/Fhi.Designsystem int…
61e7bfb 
…o 214-implement-first-iteration-of-table
@dafn
add more tokens
2c91f6e
@dafn
better example
0907272
@dafn
experiment with row elements
218b829
@dafn
fix some examples and remove unused apis
796481d
@dafn
change defaulr width
108c499
@dafn
make row set cell as header
0e94972
@fhi-designsystem-bot
clean stories
d16e20d
@fhi-designsystem-bot
Merge branch 'main' of https://github.com/FHIDev/Fhi.Designsystem int…
7c6ef03 
…o 214-implement-first-iteration-of-table
@fhi-designsystem-bot
only apply header variant to child cells
43ef619
@fhi-designsystem-bot
add api definition for fhi-table
6e1431c
@fhi-designsystem-bot
add api definitions forsub-components
58ee307
@dafn
work with new table component tokens
891e75c
@dafn
Merge branch 'main' of https://github.com/FHIDev/Fhi.Designsystem int…
555169e 
…o 214-implement-first-iteration-of-table
@fhi-designsystem-bot
add zebra example implementation
843615a
@fhi-designsystem-bot
add jsdocs
245ce01
@fhi-designsystem-bot
zebra -> striped
921bc43
@fhi-designsystem-bot
update story
56d0591
@fhi-designsystem-bot
clean up
4711fca
@fhi-designsystem-bot
wip table border
9b136f4
@dafn
Copy link
Copy Markdown
Collaborator Author

dafn commented Apr 16, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-406.westeurope.5.azurestaticapps.net

@dafn
Copy link
Copy Markdown
Collaborator Author

dafn commented Apr 16, 2026

Staging NPM Package published: @fhidev/pull-request-designsystem-406@0.0.760
View on GitHub Packages

@dafn
Copy link
Copy Markdown
Collaborator Author

dafn commented Apr 16, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-406.westeurope.5.azurestaticapps.net

@dafn
Copy link
Copy Markdown
Collaborator Author

dafn commented Apr 16, 2026

Staging NPM Package published: @fhidev/pull-request-designsystem-406@0.0.761
View on GitHub Packages

@dafn
Copy link
Copy Markdown
Collaborator Author

dafn commented Apr 16, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-406.westeurope.5.azurestaticapps.net

@dafn
Copy link
Copy Markdown
Collaborator Author

dafn commented Apr 17, 2026

Staging NPM Package published: @fhidev/pull-request-designsystem-406@0.0.762
View on GitHub Packages

@dafn
Copy link
Copy Markdown
Collaborator Author

dafn commented Apr 17, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-406.westeurope.5.azurestaticapps.net

trybern
trybern reviewed Apr 20, 2026
View reviewed changes
Comment thread packages/fhi-designsystem/src/components/table/fhi-table-cell/fhi-table-cell.component.ts Outdated
--fhi-table-cell-justify-content: start;
--fhi-table-cell-align-items: center;

display: flex;
Copy link
Copy Markdown
Contributor

@trybern trybern Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I HTML kan man sette table, table-row og table-cell på display.

Mest for å få det dokumentert: Hvorfor brukes ikke de i dette tilfellet på våre komponenter som jo skal gjenskape det ganske så likt?

Copy link
Copy Markdown
Collaborator Author

@dafn dafn Apr 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette er eldre og lite dokumentert spec som omfatter mange fler table-valg enn bare de tre du listet. Jeg ønsket ikke å grave meg ned i dette da jeg så HTML <table> sine begrensninger med shadow-dom.

Grid er en moderne, bedre dokumentert og mer aktivt vedlikeholdt del av spec-en, så jeg valgte det.

Comment thread packages/fhi-designsystem/src/components/table/fhi-table-cell/fhi-table-cell.component.ts Outdated
@dafn
Copy link
Copy Markdown
Collaborator Author

dafn commented Apr 21, 2026

Staging NPM Package published: @fhidev/pull-request-designsystem-406@0.0.766
View on GitHub Packages

@dafn
Copy link
Copy Markdown
Collaborator Author

dafn commented Apr 21, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-406.westeurope.5.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trybern trybern trybern left review comments

@Masuso Masuso Masuso left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement first iteration of Table

4 participants

@dafn @trybern @Masuso @fhi-designsystem-bot