Skip to content

Update UK Biobank variant page URL to pheweb.org/UKB-TOPMed #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −3
Draft

Update UK Biobank variant page URL to pheweb.org/UKB-TOPMed #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f59be2
Initial plan
Copilot Feb 19, 2026
4670e04
Update UK Biobank variant page URL to new format
Copilot Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/src/components/Variant/Variant.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ test('createBioBankURL', () => {
const rsid = "rs534125149";
const variant = {chromosome: 16, position: 20341705, reference: 'C', alternate: 'CA'};
expect(createBioBankURL(null)({rsid,mapping})).toStrictEqual(undefined);
expect(createBioBankURL(variant)({rsid,mapping})).toStrictEqual({"rsid": "rs534125149", "url": "http://pheweb.sph.umich.edu/SAIGE-UKB/variant/16-20353028-C-CA"});
expect(createBioBankURL(variant)({rsid,mapping})).toStrictEqual({"rsid": "rs534125149", "url": "https://pheweb.org/UKB-TOPMed/variant/16-20353028-C-CA"});
});

test('summaryRSIDS', () => {
Expand Down Expand Up @@ -174,7 +174,7 @@ test('regression test generate', async () => {
const testCases :TestGenerate[] = [
{ data : with_rsid ,
variant : "16-20341705-C-CA",
expected : [{"rsid": "rs35830321", "url": "http://pheweb.sph.umich.edu/SAIGE-UKB/variant/16-20353028-C-CA"}]
expected : [{"rsid": "rs35830321", "url": "https://pheweb.org/UKB-TOPMed/variant/16-20353028-C-CA"}]
},
{ data : with_rsid ,
variant : "",
Expand Down
2 changes: 1 addition & 1 deletion ui/src/components/Variant/Variant.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export const createBioBankURL = (v : CommonVariantModel | undefined) => (rsidMap
const rsid = rsidMapping.rsid;

if(v && mapping && rsid){
const url : string = `http://pheweb.sph.umich.edu/SAIGE-UKB/variant/${mapping.seq_region_name}-${mapping.start}-${v.reference}-${v.alternate}`
const url : string = `https://pheweb.org/UKB-TOPMed/variant/${mapping.seq_region_name}-${mapping.start}-${v.reference}-${v.alternate}`
bioBankURL = { rsid , url};
} else {
bioBankURL = undefined;
Expand Down