Merged
Conversation
pulledtim
approved these changes
May 30, 2023
wistefan
added a commit
that referenced
this pull request
Mar 5, 2026
## Summary - Replace `TrustBlocValidator` with custom `CredentialValidator` supporting modes: none, combined, jsonLd, baseContext - Remove `JWTVerfificationMethodResolver` (no longer needed) - Remove `originalVC` bridge from `common/credential.go` - Remove trustbloc `verifiable` import from `jwt_verifier.go` ## Test plan - [x] All existing tests pass - [x] New tests for baseContext rejection of custom types - [x] New tests for combined mode accepting valid credentials Co-authored-by: Stefan Wiedemann <wistefan@googlemail.com> Reviewed-on: http://localhost:3000/wistefan/verifier/pulls/10 Reviewed-by: wistefan <wistefan@googlemail.com> Co-authored-by: claude <claude@gitea.com> Co-committed-by: claude <claude@gitea.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verifier verifies agains trusted-participants-list and trusted-issuers-list.