Merged
Conversation
FL03
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+47
to
+50
| match self { | ||
| Self::Leaf(_) => true, | ||
| _ => false, | ||
| } |
Check warning
Code scanning / clippy
match expression looks like `matches!` macro
Comment on lines
+53
to
+56
| match self { | ||
| Self::Node(_, _) => true, | ||
| _ => false, | ||
| } |
Check warning
Code scanning / clippy
match expression looks like `matches!` macro
| res | ||
| pub fn merkle_hash(data: impl AsRef<[u8]>) -> H256 { | ||
| let tmp: H256 = hasher(data).into(); | ||
| hasher(&tmp).into() |
Check warning
Code scanning / clippy
the borrowed expression implements the required traits
| self.store.iter().map(|(k, _)| k) | ||
| } | ||
| /// Returns the number of elements in the matrix. | ||
| pub fn len(&self) -> usize { |
Check warning
Code scanning / clippy
struct `AdjacencyMatrix` has a public `len` method, but no `is_empty` method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.