Skip to content

V0.1.14#61

Merged
FL03 merged 58 commits intomainfrom
v0.1.14
May 25, 2024
Merged

V0.1.14#61
FL03 merged 58 commits intomainfrom
v0.1.14

Conversation

@FL03
Copy link
Copy Markdown
Owner

@FL03 FL03 commented May 11, 2024

FL03 added 8 commits May 10, 2024 15:19
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
@FL03 FL03 added bug Something isn't working enhancement New feature or request rust Improvements or additions that update the Rust code dependencies Pull requests that update a dependency file model Any additions or improvements to any models labels May 11, 2024
@FL03 FL03 added this to the v0.1.14 milestone May 11, 2024
@FL03 FL03 self-assigned this May 11, 2024
FL03 and others added 4 commits May 11, 2024 13:10
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
@FL03 FL03 linked an issue May 12, 2024 that may be closed by this pull request
FL03 added 8 commits May 12, 2024 11:51
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
FL03 added 2 commits May 19, 2024 15:12
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
FL03 and others added 14 commits May 20, 2024 09:39
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
@FL03 FL03 marked this pull request as ready for review May 24, 2024 17:05
Signed-off-by: Joe McCain III <92560746+FL03@users.noreply.github.com>
Comment on lines +12 to +37
pub trait SummaryStatistics
where
Self::Item: FromPrimitive,
Self::Output: NumOps<Self::Item, Self::Output>,
{
type Item;
type Output;

fn elems(&self) -> Self::Item {
Self::Item::from_usize(self.len()).unwrap()
}

fn len(&self) -> usize;

fn mean(&self) -> Self::Output {
self.sum() / self.elems()
}

fn product(&self) -> Self::Output;

fn sum(&self) -> Self::Output;

fn std(&self) -> Self::Output;

fn var(&self) -> Self::Output;
}

Check warning

Code scanning / clippy

trait `SummaryStatistics` has a `len` method but no (possibly inherited) `is_empty` method

trait `SummaryStatistics` has a `len` method but no (possibly inherited) `is_empty` method
Comment thread core/src/nn/mask/mod.rs
*/
pub use self::mask::*;

pub(crate) mod mask;

Check warning

Code scanning / clippy

module has the same name as its containing module

module has the same name as its containing module
Comment thread core/src/nn/mask/mask.rs
S: Data,
T: DataMut<Elem = A>,
{
data.zip_mut_with(&mut self.0, |x, &m| {

Check warning

Code scanning / clippy

the method `zip_mut_with` doesn't need a mutable reference

the method `zip_mut_with` doesn't need a mutable reference

toggle!(enum C, R);

///

Check warning

Code scanning / clippy

empty doc comment

empty doc comment
self.plan().iter()
}

pub fn len(&self) -> usize {

Check warning

Code scanning / clippy

struct `FftPlan` has a public `len` method, but no `is_empty` method

struct `FftPlan` has a public `len` method, but no `is_empty` method

fn masked_fill(&self, mask: &Array<bool, D>, value: A) -> Self::Output {
let mut arr = self.clone();
arr.zip_mut_with(&mask, |x, &m| {

Check warning

Code scanning / clippy

this expression creates a reference which is immediately dereferenced by the compiler

this expression creates a reference which is immediately dereferenced by the compiler
Comment on lines +26 to +30
pub trait SequenceIter {
type Item;

fn len(&self) -> usize;
}

Check warning

Code scanning / clippy

trait `SequenceIter` has a `len` method but no (possibly inherited) `is_empty` method

trait `SequenceIter` has a `len` method but no (possibly inherited) `is_empty` method
Signed-off-by: Joe McCain III <92560746+FL03@users.noreply.github.com>
@FL03 FL03 merged commit d09a22b into main May 25, 2024
@FL03 FL03 deleted the v0.1.14 branch May 25, 2024 06:59
@FL03 FL03 linked an issue May 27, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request model Any additions or improvements to any models rust Improvements or additions that update the Rust code

Projects

None yet

2 participants