Skip to content

Delete and recreate GDML file each time #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mvicenzi merged 1 commit into from
Sep 11, 2025
Merged

Delete and recreate GDML file each time #22

mvicenzi merged 1 commit into from
Sep 11, 2025

Conversation

@mvicenzi
Copy link
Member

@mvicenzi mvicenzi commented Sep 11, 2025

Closes #14

@mvicenzi mvicenzi self-assigned this Sep 11, 2025
@mvicenzi mvicenzi added the bug Something isn't working label Sep 11, 2025
@mvicenzi mvicenzi linked an issue Sep 11, 2025 that may be closed by this pull request
Re-create GDML file at each execution #14
Closed
benw22022
benw22022 approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@benw22022 benw22022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mvicenzi for this fix, looks good to me! Sorry I've not had a chance to review #21 yet, been a bit busy with FASER stuff over the past couple of weeks - will get a chance early next week

@mvicenzi mvicenzi merged commit fc5d3f9 into main Sep 11, 2025
@mvicenzi mvicenzi deleted the 14-re-create-gdml-file-at-each-execution branch September 11, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benw22022 benw22022 benw22022 approved these changes

@WenjieWu-Sci WenjieWu-Sci Awaiting requested review from WenjieWu-Sci

Assignees

@mvicenzi mvicenzi

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Re-create GDML file at each execution

3 participants

@mvicenzi @benw22022