Addition of a rock envelope for background studies #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benw22022
approved these changes
Jun 13, 2025
Contributor
benw22022
left a comment
benw22022
left a comment
There was a problem hiding this comment.
Hi @mvicenzi, thanks for adding this feature! Looks good from my side! I have only one very minor comment - wondering if it might be an idea to add a simple print out to inform the user that the rock wall is enabled? Just in case someone wanted to double check the logs that the wall is enabled or not after a run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new configuration flag
/det/enableRockin the geometry construction interface to optionally include a rock envelope surrounding the FPF hall. This addition enables more complete and realistic background studies./det/enableRockflag is set to false by default.GeometricalParameters.BackgroundGenerator: background particles are generated at the entry wall of the rock volume instead of the entry wall of the hall.FPFClassesdictionary name inCMakeLists.txthas been updated to match the name of the library itself. This allows ROOT to automatically load the library without complaining.