-
Notifications
You must be signed in to change notification settings - Fork 247
"Debugging Mods" page #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Should i add how to read stacktraces btw? |
|
anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some corrections and one-click fixes. LGTM!
reference/latest/src/main/java/com/example/docs/debug/TestItem.java
Outdated
Show resolved
Hide resolved
reference/latest/src/main/java/com/example/docs/debug/TestItem.java
Outdated
Show resolved
Hide resolved
reference/latest/src/main/java/com/example/docs/debug/TestItem.java
Outdated
Show resolved
Hide resolved
reference/latest/src/main/java/com/example/docs/debug/TestItem.java
Outdated
Show resolved
Hide resolved
There are still some small leftovers with small typos. Shouldn't be too much until it's fixed now! Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
|
Some are still open, not sure how to adjust suggestions for the 1 or 2 typo fixes 🥴 |
|
Check them out, I've fixed the spellings. |
Typos were fixed in the suggestions; this should be it! Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
|
Looks good to me, thank you for the help 😃 |
|
oh but mby add yourself to the authors too? |
its-miroma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just drop that image, then LGTM!
The Oak Logger thing can wait (:
Oak Logger as in, giving the logger the custom name instead of the modid? Or just print some funny stuff? |
its-miroma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ty!
Added its-miroma to authors Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
|
Little nitpick, I guess... but we can't use the HTML image tag to resize the image, right? @its-miroma
|
develop/debugging.md
Outdated
|
|
||
| Missing assets and textures (the Purple & Black placeholder) also log a warning to the console, and usually mention the expected values. | ||
|
|
||
|  |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore that, that's a false positive, I'll fix it another time.
Hopefully the syntax works tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:(
either leave it at 16×16, or git revert e6f8ce8eed2b813688321ce574d83fc26ae69a8a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh im tending more towards reverting the commit... this way the docs are a bit more independent of the minecraft.wiki assets too
This reverts commit e6f8ce8 due to having upscaling interoplation issues in addition to linting warnings.
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit 1e90bfc)
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit 1e90bfc)
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit 1e90bfc)



This page describes how to use the logger and debugging in general.
This is a rough port of the previous project's wiki page which I also have created back then.