Skip to content

Conversation

@JR1811
Copy link
Contributor

@JR1811 JR1811 commented May 16, 2025

This page describes how to use the logger and debugging in general.

This is a rough port of the previous project's wiki page which I also have created back then.

@JR1811 JR1811 requested review from a team as code owners May 16, 2025 13:40
@netlify
Copy link

netlify bot commented May 16, 2025

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit c94c79e
🔍 Latest deploy log https://app.netlify.com/projects/nimble-elf-d9d491/deploys/68979176ed73f30008703b02
😎 Deploy Preview https://deploy-preview-330--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@JR1811
Copy link
Contributor Author

JR1811 commented May 16, 2025

Should i add how to read stacktraces btw?

@its-miroma its-miroma added new-content A new page or set of pages todo:verify This needs to be reviewed priority:low This is nice to have, but it can wait a little labels May 16, 2025
@its-miroma its-miroma mentioned this pull request May 16, 2025
8 tasks
@its-miroma its-miroma changed the title Added basic problem solving page "Basic Problem Solving" page May 16, 2025
@its-miroma its-miroma changed the title "Basic Problem Solving" page "Debugging Mods" page Jul 14, 2025
@JR1811
Copy link
Contributor Author

JR1811 commented Jul 27, 2025

anything else?

@its-miroma its-miroma self-requested a review July 28, 2025 05:26
Copy link
Member

@its-miroma its-miroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some corrections and one-click fixes. LGTM!

@its-miroma its-miroma removed the request for review from a team July 28, 2025 13:59
There are still some small leftovers with small typos. Shouldn't be too much until it's fixed now!

Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
@JR1811
Copy link
Contributor Author

JR1811 commented Aug 8, 2025

Some are still open, not sure how to adjust suggestions for the 1 or 2 typo fixes 🥴

@its-miroma
Copy link
Member

Check them out, I've fixed the spellings.

Typos were fixed in the suggestions; this should be it!

Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
@JR1811
Copy link
Contributor Author

JR1811 commented Aug 9, 2025

Looks good to me, thank you for the help 😃

@JR1811
Copy link
Contributor Author

JR1811 commented Aug 9, 2025

oh but mby add yourself to the authors too?

Copy link
Member

@its-miroma its-miroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just drop that image, then LGTM!

The Oak Logger thing can wait (:

@JR1811
Copy link
Contributor Author

JR1811 commented Aug 9, 2025

Just drop that image, then LGTM!

The Oak Logger thing can wait (:

Oak Logger as in, giving the logger the custom name instead of the modid?

Or just print some funny stuff?

its-miroma
its-miroma previously approved these changes Aug 9, 2025
Copy link
Member

@its-miroma its-miroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ty!

@its-miroma its-miroma added stage:ready and removed todo:verify This needs to be reviewed labels Aug 9, 2025
Added its-miroma to authors

Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
its-miroma
its-miroma previously approved these changes Aug 9, 2025
@JR1811
Copy link
Contributor Author

JR1811 commented Aug 9, 2025

Little nitpick, I guess... but we can't use the HTML image tag to resize the image, right? @its-miroma

grafik


Missing assets and textures (the Purple & Black placeholder) also log a warning to the console, and usually mention the expected values.

![Missing asset](https://minecraft.wiki/images/Missing_Texture_JE4.png)

This comment was marked as outdated.

Copy link
Contributor Author

@JR1811 JR1811 Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it complains only if the width and height are specified after...

grafik

Copy link
Member

@its-miroma its-miroma Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore that, that's a false positive, I'll fix it another time.
Hopefully the syntax works tho

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax works, but seems like there is some interpolation goin on with that...

grafik

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(
either leave it at 16×16, or git revert e6f8ce8eed2b813688321ce574d83fc26ae69a8a

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh im tending more towards reverting the commit... this way the docs are a bit more independent of the minecraft.wiki assets too

This reverts commit e6f8ce8 due to
having upscaling interoplation issues in addition to linting warnings.
@its-miroma its-miroma merged commit 1e90bfc into FabricMC:main Sep 7, 2025
7 checks passed
@its-miroma its-miroma removed the priority:low This is nice to have, but it can wait a little label Sep 17, 2025
kevinthegreat1 pushed a commit to kevinthegreat1/fabric-docs that referenced this pull request Oct 14, 2025
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
(cherry picked from commit 1e90bfc)
kevinthegreat1 pushed a commit to kevinthegreat1/fabric-docs that referenced this pull request Oct 14, 2025
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
(cherry picked from commit 1e90bfc)
kevinthegreat1 pushed a commit to kevinthegreat1/fabric-docs that referenced this pull request Oct 15, 2025
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
(cherry picked from commit 1e90bfc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-content A new page or set of pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants