Skip to content

Conversation

@kevinthegreat1
Copy link
Contributor

Rollup is a dependency of vite, which is a dependency of vitepress. rolldown is a beta rust rewrite of rollup and is planned to replace rollup. This pr switches vite to rolldown-vite, the beta version of vite using rolldown which is planned to replace vite.

Using rolldown gives a significant performance improvement, and allows us to build the entire website in less than 3GB of ram (including the versions I added back). This pr also adds back versions previously deleted, namely 1.21.4 and 1.21.8.

I believe the usage of beta software is justified in this case, as it is planned to replace its respective packages.

@kevinthegreat1 kevinthegreat1 requested review from a team as code owners October 14, 2025 22:58
@netlify
Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 75c30fb
🔍 Latest deploy log https://app.netlify.com/projects/nimble-elf-d9d491/deploys/68eed7ef6aefd90008ecf5c0
😎 Deploy Preview https://deploy-preview-371--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@modmuss50
Copy link
Member

Can you split this PR to only switch to rolldown? its impossible to review like this.

@kevinthegreat1
Copy link
Contributor Author

Done. Sorry about that.

@modmuss50
Copy link
Member

Thanks, I'll take a look shortly. As you guessed I'm not super keen on using beta software, but if it's going to get improvements/fixes faster than what we have now that can only be a good thing.

@its-miroma its-miroma added framework Related to the VitePress framework todo:verify This needs to be reviewed priority:high This should be addressed before anything else labels Oct 15, 2025
@modmuss50
Copy link
Member

Lets try it, worse case we roll back.

@modmuss50 modmuss50 merged commit e0fea54 into FabricMC:main Oct 15, 2025
7 checks passed
@kevinthegreat1 kevinthegreat1 deleted the rolldown branch October 15, 2025 18:20
kevinthegreat1 added a commit to kevinthegreat1/fabric-docs that referenced this pull request Oct 15, 2025
* Switch to rolldown

* Fix update script

* Update node to update npm to fix npm/cli#4828

(cherry picked from commit e0fea54)
@its-miroma its-miroma added stage:ready and removed todo:verify This needs to be reviewed labels Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework Related to the VitePress framework priority:high This should be addressed before anything else

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants