-
Notifications
You must be signed in to change notification settings - Fork 253
Switch to Rolldown #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Rolldown #371
Conversation
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Can you split this PR to only switch to rolldown? its impossible to review like this. |
3db6cba to
75c30fb
Compare
|
Done. Sorry about that. |
|
Thanks, I'll take a look shortly. As you guessed I'm not super keen on using beta software, but if it's going to get improvements/fixes faster than what we have now that can only be a good thing. |
|
Lets try it, worse case we roll back. |
* Switch to rolldown * Fix update script * Update node to update npm to fix npm/cli#4828 (cherry picked from commit e0fea54)
Rollup is a dependency of vite, which is a dependency of vitepress. rolldown is a beta rust rewrite of rollup and is planned to replace rollup. This pr switches vite to rolldown-vite, the beta version of vite using rolldown which is planned to replace vite.
Using rolldown gives a significant performance improvement, and allows us to build the entire website in less than 3GB of ram (including the versions I added back). This pr also adds back versions previously deleted, namely 1.21.4 and 1.21.8.
I believe the usage of beta software is justified in this case, as it is planned to replace its respective packages.