Skip to content

Conversation

@dicedpixels
Copy link
Contributor

A simple page for custom key mappings.

@dicedpixels dicedpixels requested a review from a team as a code owner December 24, 2025 15:23
@netlify
Copy link

netlify bot commented Dec 24, 2025

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 6dfd19c
🔍 Latest deploy log https://app.netlify.com/projects/nimble-elf-d9d491/deploys/69575ef1127af600081c7c48
😎 Deploy Preview https://deploy-preview-437--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@its-miroma its-miroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're never escaping the Misc category, aren't we...

@its-miroma its-miroma added the new-content A new page or set of pages label Dec 24, 2025

@[code lang=java transcludeWith=:::client_tick_event](@/reference/latest/src/client/java/com/example/docs/keymapping/ExampleModKeyMappingsClient.java)

This will print "Key Pressed!" to the in-game chat every time the mapped key is pressed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This will print "Key Pressed!" to the in-game chat every time the mapped key is pressed.
This will print "Key Pressed!" to the in-game chat every time the mapped key is pressed. Keep in mind that holding the key will repeatedly print the message to the chat, so you might want to implement guards so this logic only triggers once.

to avoid repeating "logic"

Copy link
Contributor Author

@dicedpixels dicedpixels Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that the repeating logic could the desired behavior. There could be a valid use case for repeated execution, like a gun or something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be, but it bears mentioning in case the intending use case is something that shouldn't be repeatedly triggered like a config change or opening a screen.


@[code lang=java transcludeWith=:::client_tick_event](@/reference/latest/src/client/java/com/example/docs/keymapping/ExampleModKeyMappingsClient.java)

This will print "Key Pressed!" to the in-game chat every time the mapped key is pressed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This will print "Key Pressed!" to the in-game chat every time the mapped key is pressed.
This will print "Key Pressed!" to the in-game chat every time the mapped key is pressed. Keep in mind that holding the key will repeatedly print the message to the chat, so you might want to implement guards so this logic only triggers once.

to avoid repeating "logic"

@cassiancc cassiancc requested a review from its-miroma January 2, 2026 17:21
Copy link
Member

@its-miroma its-miroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait no, there's still an unsatisfied suggestion by @cassiancc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-content A new page or set of pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants