update CI workflows #439
Draft
update CI workflows #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its-miroma
added
framework
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
its-miroma
force-pushed
the
action
branch
2 times, most recently
from
890435c to
640a654
Compare
modmuss50
reviewed
Dec 27, 2025
`publish.yml` only ran additional steps on top of `build.yml`'s, so we can stay DRY by moving the `deploy` job to `build.yml`. This has the (positive?) side effect of requiring success in building the mod and running its game tests before changes are deployed to prod. Other changes: - rename `build.yml` to `build.yaml`, see <https://yaml.org/faq> - use "temurin" as Java distribution, which we recommend in the docs - publish checkstyle report before checking datagen
- extend the `format` workflow to also check that files are Prettier - rename `markdownlint.yml` to `format.yaml` - avoid fetching all repo history, not needed
inspired by <https://github.com/modrinth/code/tree/7de4e55badd38aa969fb7181f5889e9f03ab757b/.github/workflows> Co-authored-by: Cal H. <contact@cal.engineer> Co-authored-by: Prospector <6166773+Prospector@users.noreply.github.com> Other changes: - lock third-party actions to a commit hash - use peculiar naming for commits, inspired by old Minecraft snapshots - add caching when pushing sources, which allows Crowdin to push diffs - add `preserve_hierarchy` and `project_id` to `crowdin.yaml`. see <https://github.com/crowdin/github-action#migration-from-the-native-github-integration> Important note regarding the implementation: the action currently creates a branch i18n/main on the main repo and opens a PR to main. This requires changing an option in the repo's settings to allow Actions to create PRs to the same repo. alternatively, the action authors recommend setting it up with a machine account, such as FabricMCBot, who would fork the repo, push translations to their own branch, and open a PR to upstream. see <https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#push-pull-request-branches-to-a-fork>
"Internationalization [i18n] is the design and development of a product [...] that enables easy localization [...]." "Localization [l10n] refers to the adaptation of a product [...] to meet the language [...] of a specific target marker (a 'locale')." see <https://www.w3.org/International/questions/qa-i18n>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm waiting for Modrinth to confirm that their workflows are licensed under MIT.
Please read through the commit messages, which contain important context and summary