use Google Fonts, fix lang attribute #445
Conversation
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
use JetBrains Mono and Noto Color Emoji from Google Fonts use a hyphen for the lang attribute
|
Font changes are pretty invisible to my eyes, even switching side by side, so no issues there for me. I definitely would not want serifs in the body, though I wouldn't be opposed to testing how it looks in a header. As long as there's fallback fonts, other language support shouldn't be an issue as far as I know. |
| font-display: swap; | ||
| } | ||
| /* Google Fonts: JetBrains Mono, Noto Color Emoji (Windows does not render flags) */ | ||
| @import url("https://fonts.googleapis.com/css2?family=JetBrains+Mono:ital,wght@0,100..800;1,100..800&family=Noto+Color+Emoji&display=swap"); |
There was a problem hiding this comment.
Is it possible to not have any external CDN dependencies? Im not strongly against this, it just feels nicer not to have them.
There was a problem hiding this comment.
I have just found: https://fontsource.org/docs/getting-started/introduction It has both these fonts in a way that we should be able to easily depend on via npm. This is much better than including them in the repo or pulling them from google.
There was a problem hiding this comment.
Reading into it, Google Fonts doesn't seem to be reliable long-term, as breaking changes get introduced without opt-out.
see: google/fonts#1307
I'll take a look at fontsource
There was a problem hiding this comment.
Reading into it, Google Fonts doesn't seem to be reliable long-term, as breaking changes get introduced without opt-out.
see: google/fonts#1307
I'll take a look at fontsource
3 participants
I'd appreciate feedback on font choices. I chose JetBrains Mono which afaik is used in IntelliJ. I did not embed the fonts directly, rather I used Google Fonts.
I also used Noto Color Emoji for flags, instead of tracking the woff2 file in the repo.
Do you wish the Docs had more personality in their font choice? Maybe a Serif, or something different for headings vs paragraphs?
Are any languages broken because the fonts we're using don't support their characters fully?