Skip to content

Action's comments - 2 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FabrizioSandri merged 4 commits into from
Jul 29, 2022
Merged

Action's comments - 2 #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9edd4f9
input columns removed
FabrizioSandri Jul 29, 2022
ba694f1
moved the comment identifier at the beginning to avoid truncation
FabrizioSandri Jul 29, 2022
08bfaa5
dput problem fix, missing collapse parameter
FabrizioSandri Jul 29, 2022
8e3401b
file hyperlink fix
FabrizioSandri Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ runs:
// Find the comment generated by RcppDeepState-action
const comment_identifier = "<!-- RcppDeepState-action comment-->"
const action_comment = comments.find(comment => comment.body.includes(comment_identifier))
const new_comment_body = `## RcppDeepState Report\n${report}\n${comment_identifier}`
const new_comment_body = `${comment_identifier}\n## RcppDeepState Report\n${report}`

if (action_comment) {
await github.rest.issues.updateComment({
Expand Down
21 changes: 10 additions & 11 deletions docker/src/analyze_package.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,13 @@ getFunctionName <- function(test_path) {
getHyperlink <- function(analyzed_file) {
file_ref <- gsub(" ", "", analyzed_file)
refs <- unlist(strsplit(file_ref, ":"))
file_hyperlink <- paste(GitHub_server_url, GitHub_repository, "blob",
GitHub_head_ref, location, "src", refs[1], sep="/")

file_hyperlink <- paste(GitHub_repository, "blob", GitHub_head_ref, location,
"src", refs[1], sep="/")
line_hyperlink <- gsub("[/]+", "/", paste0(file_hyperlink, "#L", refs[2]))
final_hyperlink <- paste(GitHub_server_url, line_hyperlink, sep="/")

gh_link <- paste0("[",file_ref,"](",line_hyperlink,")")
gh_link <- paste0("[",file_ref,"](",final_hyperlink,")")
}

# this function generates a markdown version of an input list
Expand All @@ -71,7 +73,7 @@ getInputsMarkdown <- function(inputList) {

# helper function that generates the code for a test given the inputs
getExecutableFile <- function(inputs, function_name) {
inputList <- capture.output(dput(inputs))
inputList <- paste(capture.output(dput(inputs)), collapse="")
executable_file <- paste0("testlist <- ", inputList, "<br/>",
"result <- do.call(", package_name, "::",
function_name, ", testlist)")
Expand Down Expand Up @@ -103,8 +105,8 @@ if (any(errors)) {
first_error_table <- error_table[,.SD[1], by=func]

# generate the report file
report_table <- data.table(function_name=c(), message=c(), inputs=c(),
file_line=c(), address_trace=c(), R_code=c())
report_table <- data.table(function_name=c(), message=c(), file_line=c(),
address_trace=c(), R_code=c())

for (i in seq(dim(first_error_table)[1])) {

Expand All @@ -115,14 +117,11 @@ if (any(errors)) {
}

message <- first_error_table$logtable[[i]]$message[1]

inputs_markdown <- getInputsMarkdown(first_error_table$inputs[[i]])
executable_file <- getExecutableFile(first_error_table$inputs[[i]],
first_error_table$func[i])

new_row <- data.table(function_name=first_error_table$func[i],
inputs=inputs_markdown, message=message,
file_line=file_line_link,
new_row <- data.table(function_name=first_error_table$func[i],
message=message, file_line=file_line_link,
address_trace=address_trace_link,
R_code=executable_file)
report_table <- rbind(report_table, new_row)
Expand Down