Merged
Conversation
adds the ability to format the number as a timer with various presets
if panels are expected to be found by name then the name should be unique by default, the Countdown component requires this because it now re-uses the DestroyPanel function from the main class, but other branches like the animation branch benefit from this aswell
4 tasks
just resets the Update Invoke
switch to using InvokeHandler based Invokes to avoid FP's client hashing from breaking text invokes, its possible nameof could have worked but i dont know enough about their build step to confirm that
undo invoke changes as there is a fix for string based invokes
Contributor
Removed the new GUID for every unnamed component - this broke our internal community UI test and would have likely posed issues for general back compatibility Some minor formatting changes Thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improving the Countdown Component
Changed the countdown component to be useful for any counting/timer operation by supporting float parameters
fully ensuring backwards compatibility (as JSON auto converts ints to float)
added optional
intervalcomponent to seperately control update rate from step amountadded optional
destroyIfDoneparameter (defaults to true to maintain old behaviour), allows keeping the timer text arround after its finished countingadded
timerFormatenum that formats the number into a variety of timer presetsadded
numberFormatoption to be passed into the ToString() functionTimerExample.mp4