Fd 1059 circle ci #109
Merged
Fd 1059 circle ci #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected some dependencies in the lock file for unit tests
Yml files cannot handle tabs
.circleci/config.yml
Outdated
| build: | ||
| docker: | ||
| # specify the version | ||
| - image: circleci/golang:1.10 |
.circleci/config.yml
Outdated
| test: | ||
| working_directory: /tmp # All the binaries are saved here | ||
| docker: | ||
| - image: circleci/golang:1.10 |
| - unicode/norm | ||
| - name: google.golang.org/genproto | ||
| version: a7e196e89fd3a3c4d103ca540bd5dac3a736e375 | ||
| version: 32ee49c4dd805befd833990acba36cb75042378c |
Contributor
There was a problem hiding this comment.
this changes from the latest (a7e19) to one from a year ago (32ee49)
Contributor
Author
There was a problem hiding this comment.
hmm, that was glide update choosing that. I'll get it to the latest verison
Contributor
There was a problem hiding this comment.
sigh, when steven updated this to the latest one, his tests would not pass.
Contributor
Author
There was a problem hiding this comment.
This dep is not in any core functionality, only used during the test suite.
Updating it breaks said tests
carryforward
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added circle ci. Needed to make some dependency adjustments to pass unit tests.
There are some function definition changes in this that needed to be updated in factomd to enable all unit tests to compile + pass.