Fd 1071 adding sequence #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
requested changes
Jun 21, 2019
Contributor
Emyrk
left a comment
Emyrk
left a comment
There was a problem hiding this comment.
Change the call of DBlockByHeight, rather than modifying it's response
dblock.go
Outdated
| // TODO: we need a better api call for dblock by keymr so that API will | ||
| // retrun the same as dblock-byheight | ||
| return GetDBlockByHeight(db.Header.SequenceNumber) | ||
| dblockHold, rawHold, errHold := GetDBlockByHeight(db.Header.SequenceNumber) |
Contributor
There was a problem hiding this comment.
The sequence number is just the dblock height. It's an odd term for it, but was probably done to match the json response for the eblock.
Can you push this sequence number adjustment to inside GetDBlockByHeight? This way both calls return the same result whether you call by height or by keymr. When you call GetDBlockByHeight, you'll have to set the wrap.DBlock.SequenceNumber to the parameter height.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.