AP 484 #126
Merged
AP 484 #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is work done by Daniel, I made the PR because I clicked the PR button.. |
Emyrk
commented
Oct 21, 2019
dblock.go
Outdated
| } | ||
|
|
||
| // ReplayDBlockFromHeight requests DBlock states to be emitted over the LiveFeed API | ||
| func ReplayDBlockFromHeight(startheight int64, endheight int64) (*JSON2Response, error) { |
Contributor
Author
There was a problem hiding this comment.
Is there a reason we are returning the JSON2Response vs a type a user can more easily work with?
I'm guessing the response is something as simple as success?
We should really return the unmarshalled type here, and not have the caller do that work
Contributor
Author
|
I made the PR, but Daniel did the work. I approve 👍 |
Contributor
VeenaGondkar
left a comment
VeenaGondkar
left a comment
There was a problem hiding this comment.
Approving the changes made
VeenaGondkar
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.