Add support for transactions #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release the V1 rollup to master. This is used by factom-walletd version 2.2.16 and some pegnet software
WhoSoup
changed the title
Member
Author
|
Decided to add support for decoding the transactions in the FBlock as well, rather than just having them be raw json. |
PaulBernier
reviewed
Aug 19, 2020
Member
Author
|
Addressed the comments. Great call on the MarshalJSON unit test, managed to catch a bug where it didn't convert the timestamp properly back to millitimestamp. |
PaulBernier
approved these changes
Aug 20, 2020
PaulBernier
pushed a commit
that referenced
this pull request
Dec 19, 2020
* return useful results from pending transactions * expand fblock transactions * add support for dbheight * capitalization, unit test, time conversion Co-authored-by: Brian Deery <carryforward@users.noreply.github.com>
PaulBernier
pushed a commit
that referenced
this pull request
Dec 19, 2020
* return useful results from pending transactions * expand fblock transactions * add support for dbheight * capitalization, unit test, time conversion Co-authored-by: Brian Deery <carryforward@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar vein to #140, this changes the factom api to return a struct containing the data rather than just returning a JSON string. Includes a basic unit test.