Standardize EC Output naming #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulBernier
approved these changes
Sep 3, 2020
PaulBernier
pushed a commit
that referenced
this pull request
Dec 19, 2020
PaulBernier
pushed a commit
that referenced
this pull request
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was noticed by @ilzheev: The naming of the entry credit outputs was inconsistent across the library.
The FBlock had
OutECs:factom/fblock.go
Line 38 in 7b8f2b8
Whereas Transactions/Pending Transactions had
ECOutputs:factom/transaction.go
Line 35 in 7b8f2b8
factom/transaction_pending.go
Line 15 in 7b8f2b8
This PR renames the FBlock variable to
ECOutputs. Both the parsing of FBlock outputs and Pending Transactions are new additions in this release, whereas Transaction.ECOutputs is the one that may actually be in use. Plus, I prefer "ECOutputs" to "OutECs".The root cause is an inconsistency in the factomd api itself, due to inconsistent naming there. However, that's not something we can fix without API changes, so that would be slated for V3.