Skip to content

Validate EC/FCT outputs as such #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hannemennah merged 2 commits into from
Aug 23, 2017
Merged

Validate EC/FCT outputs as such #49

hannemennah merged 2 commits into from
Aug 23, 2017

Conversation

@hannemennah
Copy link
Contributor

@hannemennah hannemennah commented Aug 23, 2017

No description provided.

michaelbeam
michaelbeam approved these changes Aug 23, 2017
View reviewed changes
Copy link
Contributor

@michaelbeam michaelbeam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but should be merged into develop instead of master

@hannemennah hannemennah changed the base branch from master to develop August 23, 2017 19:54
@hannemennah hannemennah merged commit 0d5d5df into develop Aug 23, 2017
@hannemennah hannemennah deleted the FD-244 branch August 23, 2017 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@michaelbeam michaelbeam michaelbeam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hannemennah @michaelbeam @y3zier