build(go): Replace Glide with go modules #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Another note: go mod is aware of git tags. So use them properly with the semantic versioning and everyone will play nice. |
Contributor
Author
|
rebased on master |
Member
|
Using the newer PR #136 instead of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.11 introduces go modules for dependency management. This PR switches away from Glide to the official go modules.
Official documentation about go modules can be found here: https://golang.org/cmd/go/#hdr-Preliminary_module_support
Please note that go modules assume semantic versioning. No non-backwards compatible changes to this repo may be made without officially bumping to v2. This is a Good Thing (tm) because now we can really refactor this library without breaking things for other people who depend on the previous version of the library. Anyone wanting to use the new version would include "github.com/FactomProject/factom/v2" instead and everyone else will be unaffected. The
go getandgo buildcommands are now aware of such versioning so it will do the Right Thing.