Skip to content
This repository was archived by the owner on May 13, 2025. It is now read-only.

Bug fixes and additional suffix sort algorithms#1

Open
jzebedee wants to merge 1 commit intoFaithlife:masterfrom
jzebedee:master
Open

Bug fixes and additional suffix sort algorithms#1
jzebedee wants to merge 1 commit intoFaithlife:masterfrom
jzebedee:master

Conversation

@jzebedee
Copy link
Copy Markdown
Contributor

Added Yuta Mori's induced sort
Added the option to select a SuffixSort algorithm

Replaced WriteInt64 with a faster method
Fixed an erroneous throw if a patch completes without any extra data
Fixed db/eb being allocated with an extra byte
Moved constant fields together

Added the option to select a SuffixSort algorithm
Replaced WriteInt64 with a faster method
Fixed an erroneous throw if a patch completes without any extra data
Fixed db/eb being allocated with an extra byte
Moved constant fields together
@amanda-mitchell
Copy link
Copy Markdown

It appears that you changed the line endings in BinaryPatchUtility.cs, which distorts the results of blame and makes it more difficult to review the actual changes.

Could you fix the line endings and push an updated commit?

@jzebedee
Copy link
Copy Markdown
Contributor Author

Sorry to make it unclear; the source was formatted to Microsoft
convention (http://msdn.microsoft.com/en-us/library/ff926074.aspx) which
changed the indentation. You can append ?w=1 to the URL to see the diff
with whitespace ignored:

jzebedee@c563cb5?w=1

Let me know if you'd still prefer another push.

On Mon, Jul 21, 2014 at 10:53 PM, David Mitchell notifications@github.com
wrote:

It appears that you changed the line endings in BinaryPatchUtility.cs,
which distorts the results of blame and makes it more difficult to review
the actual changes.

Could you fix the line endings and push an updated commit?


Reply to this email directly or view it on GitHub
#1 (comment).

@jzebedee
Copy link
Copy Markdown
Contributor Author

David,

I've created two new pull requests for the bugfixes and added features, respectively. They should be free of any formatting quirks. Feel free to close this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants